Fix workflows/tarpaulin.yml and Add @jonhoo/flurry to benchmark. (Related #180)#238
Merged
rultor merged 11 commits intoyegor256:masterfrom Mar 20, 2025
Merged
Fix workflows/tarpaulin.yml and Add @jonhoo/flurry to benchmark. (Related #180)#238rultor merged 11 commits intoyegor256:masterfrom
rultor merged 11 commits intoyegor256:masterfrom
Conversation
… S>::remove`. (just allow it, NO changes to code logic)
`#[must_use]` has no effect when applied to a provided trait method in rustc 1.87.0-nightly (75530e9f7 2025-03-18). And we run the cargo bench need the nightly, so we MUST make these warning lines of code smile.
…bject file: No such file or directory'
… the chore part for deprecated method in dep.
Add a new friend for our benchmark: [jonhoo/flurry](https://github.com/jonhoo/flurry). And we get the new Benchmark table. The test data for this project is a bit strange. I suspect we are not using it correctly, or maybe it is missing something somewhere. Further exploration is needed. Maybe we can turn to studying the weirdness of the flurry repo to feed back to ourselves
New results of benchmarking
Revert "New results of benchmarking"
Owner
|
@rultor merge |
Collaborator
Collaborator
Owner
|
@owtotwo thanks a lot for your contribution! |
owtotwo
changed the title
owtotwo
changed the title
owtotwo
changed the title
Contributor
Author
|
Related to #180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The details are basically in the commit messages.
#[must_use]problem in nightly(2025-03-18) rustc 1.87.0 (75530e9f7) (Ref: Lint#[must_use]attributes applied to methods in trait impls rust-lang/rust#136923)