Skip to content

fix: resolve clippy warnings introduced in Rust 1.94#4049

Merged
Madoshakalaka merged 1 commit intomasterfrom
fix/clippy-warnings-rust-1.94
Mar 6, 2026
Merged

fix: resolve clippy warnings introduced in Rust 1.94#4049
Madoshakalaka merged 1 commit intomasterfrom
fix/clippy-warnings-rust-1.94

Conversation

@Madoshakalaka
Copy link
Member

Description

Rust 1.94 released today.
CI borked because clippy has become more capable.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.125 ns      │ 2.368 ns      │ 2.128 ns      │ 2.134 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.092 ns      │ 3.343 ns      │ 2.097 ns      │ 2.127 ns      │ 100     │ 1000000000

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Visit the preview URL for this PR (updated for commit c090f79):

https://yew-rs-api--pr4049-fix-clippy-warnings-l9dw5jdp.web.app

(expires Fri, 13 Mar 2026 05:45:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.236 100.272 +0.036 +0.036%
boids 168.085 168.099 +0.014 +0.008%
communication_child_to_parent 93.470 93.485 +0.016 +0.017%
communication_grandchild_with_grandparent 105.248 105.262 +0.014 +0.013%
communication_grandparent_to_grandchild 101.610 101.610 0 0.000%
communication_parent_to_child 90.899 90.899 0 0.000%
contexts 105.153 105.177 +0.023 +0.022%
counter 86.282 86.282 0 0.000%
counter_functional 88.276 88.276 0 0.000%
dyn_create_destroy_apps 90.322 90.322 0 0.000%
file_upload 99.345 99.377 +0.032 +0.032%
function_delayed_input 94.377 94.377 0 0.000%
function_memory_game 172.944 172.944 0 0.000%
function_router 406.660 406.599 -0.062 -0.015%
function_todomvc 164.163 164.163 0 0.000%
futures 235.159 235.191 +0.032 +0.014%
game_of_life 104.718 104.732 +0.015 +0.014%
immutable 255.819 255.891 +0.071 +0.028%
inner_html 80.803 80.803 0 0.000%
js_callback 109.383 109.401 +0.019 +0.017%
keyed_list 179.723 179.740 +0.018 +0.010%
mount_point 84.146 84.174 +0.028 +0.034%
nested_list 113.057 113.072 +0.016 +0.014%
node_refs 91.525 91.523 -0.002 -0.002%
password_strength 1729.151 1729.185 +0.033 +0.002%
portals 93.034 93.034 0 0.000%
router 377.207 377.158 -0.049 -0.013%
suspense 113.458 113.502 +0.044 +0.039%
timer 88.634 88.641 +0.007 +0.008%
timer_functional 98.881 98.881 0 0.000%
todomvc 142.088 142.114 +0.026 +0.019%
two_apps 86.146 86.176 +0.029 +0.034%
web_worker_fib 136.237 136.155 -0.082 -0.060%
web_worker_prime 187.465 187.383 -0.082 -0.044%
webgl 83.224 83.224 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.846 311.574 311.056 0.217
Hello World 10 495.331 518.121 502.384 6.755
Function Router 10 33539.429 34533.482 33937.983 273.873
Concurrent Task 10 1005.920 1007.720 1006.633 0.619
Many Providers 10 1083.786 1135.823 1097.277 14.932

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.861 316.654 311.930 1.951
Hello World 10 497.887 545.487 508.007 14.285
Function Router 10 33510.486 34405.984 33965.189 295.862
Concurrent Task 10 1006.446 1007.670 1007.015 0.424
Many Providers 10 1066.529 1095.168 1073.941 8.022

@Madoshakalaka Madoshakalaka marked this pull request as ready for review March 6, 2026 06:05
@Madoshakalaka Madoshakalaka merged commit 997cd5d into master Mar 6, 2026
35 checks passed
@Madoshakalaka Madoshakalaka deleted the fix/clippy-warnings-rust-1.94 branch March 6, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant