Merged
Conversation
…Scope Replace push()/pop()/append()/shift_capture_values() with snapshot() (record sizes) and rollback() (truncate on failure). Operators now write directly to the parent SemanticValues and truncate on failure, eliminating child scope allocation and copy-on-success overhead. Key changes: - PrioritizedChoice: snapshot/rollback instead of push/pop/append - Sequence: direct write to parent (no child scope) - AndPredicate/NotPredicate: always rollback (side-effect isolation) - CaptureScope: flatten vector<map> to vector<pair> with reverse search - Remove push()/pop()/append()/shift_capture_values() entirely Benchmark (A/B, big.sql ~1.2MB): 105.4ms -> 99.2ms (-5.9%) Small inputs benefit more (TPC-H Q1: -22.7%) where per-rule allocation overhead is proportionally higher. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…in parsing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…r improved parsing performance
…tion in benchmarks
…oved readability and performance
…ing for improved parsing performance
… improved code reuse and maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #316