Repository navigation
Native template fixes perbid - #30
Merged
william-harris merged 7 commits intoOct 20, 2026
Merged
william-harris merged 7 commits into
william-harris merged 7 commits into
Conversation
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
nkloeber
requested changes
Aug 31, 2026
nkloeber
left a comment
nkloeber
left a comment
There was a problem hiding this comment.
Overall, I think the migration is good. Before upstreaming, I would address the correctness/compatibility issues from the review, especially the single-media-type requirement, floor handling, customParams, native reconciliation and request-id handling.
For the final public-PR cleanup, could we also:
- update
modules/yieldlabBidAdapter.mdfor the new/ortbflow and its compatibility constraints, and link anydocs.prebid.orgPR in the description - add and export types for the public bidder params (
adslotId,supplyId,targeting,extId,customParams) - squash
9cb47c1a5with54c9c0708-> the former deliberately leaves one test red and the latter fixes it, so the public history shouldn't contain a failing commit - rebase onto current
upstream/masterand rerun the adapter tests
I'd also keep the usual Yieldlab Bid Adapter: prefix -> the last two commits currently use Yieldlab:.
william-harris
force-pushed
the
native-template-fixes-perbid
branch
from
October 12, 2026 13:06
54c9c07 to
addab70
Compare
NOTE: one test is deliberately RED and fails on this commit - "a publisher using the standard mediaTypes.native shorthand gets a usable native bid" It expresses the desired behaviour rather than the current one. The following commit adds the facet-type mapping fix and re-scopes it. Suite here is 50 passed / 1 failed; that failure is the bug, not a broken test.
Fixes the native regression documented by the tests in the previous commit.
Send each ad unit's media types for the adslot to decide, mark requests with ext.vm.client, drop helpers the converter already covers, and document floors and the bidder params. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keep honouring params.iabContent over first-party content, prefer an explicit livestream over the live alias regardless of key order, and ignore an iabContent that is not a plain object. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The floors module's ORTB processors write imp.bidfloor and a floor per media type, and the endpoint applies the one for the adslot's media type and ignores currencies it can't convert, so the adapter's own lookup goes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Join a keywords array into the comma-separated string the endpoint requires, as /yp did, and give the iabContent docs and types the OpenRTB 2.6 shapes the endpoint validates against. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
william-harris
force-pushed
the
native-template-fixes-perbid
branch
from
October 12, 2026 13:12
addab70 to
017b459
Compare
rey1128
reviewed
Oct 16, 2026
- Type bid request params as YieldlabBidderParams in JSDoc - Describe ext.vm.client only as identifying traffic origin - Drop confusing request id and ext.origin test assertions - Rename the DSA test and drop its adomain comments Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rey1128
self-requested a review
October 19, 2026 12:24
rey1128
approved these changes
Oct 19, 2026
william-harris
merged commit Oct 20, 2026
59c04ec
into
Yieldlab_Bid_Adapter_Switch_To_Post_Open_RTB_Converter
106 of 109 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.