make Literal::Array#push accept multiple values#141
Merged
Conversation
The current implementation of `#push` was only allowing for one value to be passed in, but if the goal is to match ruby's functionality, then it should accept multiple. We also want to ensure that we perform the right type checking logic for both scenarios.
While we're here, let's add the `#append` method alias.
phillipspc
force-pushed
the
push-multiple-values
branch
from
3d2b24f to
882cd83
Compare
phillipspc
commented
Nov 11, 2024
| def push(*value) | ||
| case value | ||
| when ::Array | ||
| Literal::Array(@__type__).new(*value) |
Contributor
Author
There was a problem hiding this comment.
This seemed like the best way of forcing the type check to happen on an array of values. But 🤷♂️
Collaborator
|
Thanks @phillipspc ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #134
The current implementation of
#pushwas only allowing for one value tobe passed in, but if the goal is to match ruby's functionality, then it
should accept multiple.
We also want to ensure that we perform the right type checking logic for
both scenarios.