Skip to content

Fix data structure == equality#278

Merged
joeldrapper merged 2 commits into
mainfrom
fix-data-structure-equality
Jan 22, 2025
Merged

Fix data structure == equality#278
joeldrapper merged 2 commits into
mainfrom
fix-data-structure-equality

Conversation

@joeldrapper
Copy link
Copy Markdown
Collaborator

@joeldrapper joeldrapper commented Jan 22, 2025

The generated == methods on data structures were assuming each property had a reader, which is not necessary the case. It is possible to disable readers for properties.

@joeldrapper joeldrapper marked this pull request as ready for review January 22, 2025 12:58
@joeldrapper joeldrapper merged commit bd242e0 into main Jan 22, 2025
@joeldrapper joeldrapper deleted the fix-data-structure-equality branch January 22, 2025 12:59
@segiddins
Copy link
Copy Markdown
Contributor

Does this come with a performance penalty? If so, could only read the ivar directly when there is no reader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants