Fix Xcode 13 build (alternate PR to kick CI)#1130
Fix Xcode 13 build (alternate PR to kick CI)#1130yonaskolb merged 4 commits intoyonaskolb:masterfrom
Conversation
|
Ah well, foo, that didn't work. @yonaskolb, could you approve the workflow run? |
mthole
force-pushed
the
mthole/ci-fix
branch
from
8ee21cd to
8f4af64
Compare
|
This is now green on my fork: https://github.com/mthole/XcodeGen/actions/runs/1267184165
|
|
CI is running after Collaborator approval, I approved the original repo to check it. Would you mind closing this PR? |
|
Sorry I found you have a workaround for Xcode13, let me check it |
|
i just approved it to run it on CI |
|
🤞 |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Could you place it to New Version column? ex) https://github.com/yonaskolb/XcodeGen/pull/796/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
There was a problem hiding this comment.
Could you place it to New Version column? ex) https://github.com/yonaskolb/XcodeGen/pull/796/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
Is 2.25.0 not the correct version? The most recent release is 2.24.0 currently.
There was a problem hiding this comment.
When writing about changes, the changes before releasing should be placed in the New Version column.
Before the releasing, maintainer changes the New Version with new one (i expect 2.26.0 in this case)
FYI: c3d936c
There was a problem hiding this comment.
ah sorry. its Next Version
There was a problem hiding this comment.
Roger that, I'll move the line up!
There was a problem hiding this comment.
I will actually go under 2.25.0 as I pre-emptively added that heading yesterday. Will fix in master
|
All Green 👍 |
freddi-kit
left a comment
freddi-kit
left a comment
There was a problem hiding this comment.
Looks good to me, Thank you for first contribution @mthole and nice fixing @raptorxcz !
|
@yonaskolb I think we can merge it after fixing change log |
| strategy: | ||
| matrix: | ||
| xcode: ["12"] | ||
| xcode: ["12.5.1", "13.0"] |
There was a problem hiding this comment.
Do we still need 12.5.1? @yonaskolb I think it is only takes long time to build by 2 veresion
There was a problem hiding this comment.
I think it's wise to leave both 12.5.x and 13.0, at least for a few weeks until Xcode 13 adoption is mainstream. It's a nice guard against accidentally regressing one of the major Xcode builds out there. And the builds run in parallel, so it doesn't actually take longer AFAICT.
I'd suggest revisiting and removing 12.x in a couple months.
There was a problem hiding this comment.
Agree, let's keep till there's at least a 13.1
3 participants
This is just a copy of #1129, but from my fork so I can attempt to kick CI a few times and see if I can figure out what's amiss.