fix(carthage): shell login#1179
Conversation
|
Do you have more details on why this is required? Also before accepting this PR needs a changelog entry |
|
I don't know. But last xCode version not throw environments to Shell scripts. Google say so for that feature we should init /bin/sh with -l Login parameter. And after that, Xcode will throw OS environments to builds sh scripts. Also, maybe we should make this property possible to modify? But |
|
@yonaskolb Did you know why fails testes? |
|
The fixture snapshot tests are failing because the diffs haven't been committed. Run the tests locally and push the diffs |
yonaskolb
left a comment
yonaskolb
left a comment
There was a problem hiding this comment.
Thanks. Could you also add a changelog entry under 'Next version'
|
@yonaskolb like that? |
| - Ensure fileTypes are mapped to JSON value [#1112](https://github.com/yonaskolb/XcodeGen/pull/1112) @namolnad | ||
| - Fix platform filter for package dependecies [#1123](https://github.com/yonaskolb/XcodeGen/pull/1123) @raptorxcz | ||
| - Fix Xcode 13 build [#1130](https://github.com/yonaskolb/XcodeGen/issues/1127) @raptorxcz @mthole | ||
| - Fix Monterey MacOS shell version, shell login flag for environments [#1167](https://github.com/yonaskolb/XcodeGen/issues/1167) @bimawa |
There was a problem hiding this comment.
Wrong version, but I'll move it
2 participants
Force login shell. Looks we need it for Apple Silicon CPU.
#1167