Skip to content

Simplify release workflow#2541

Merged
utam0k merged 2 commits into
youki-dev:mainfrom
jprendes:simplify-release
Dec 16, 2023
Merged

Simplify release workflow#2541
utam0k merged 2 commits into
youki-dev:mainfrom
jprendes:simplify-release

Conversation

@jprendes
Copy link
Copy Markdown
Contributor

This PR attempts to simplify the release CI workflow.
The main changes are:

  • The release tar files are generated during the Build step, removing the need to manipulate the mode of the executable files
  • The Create Draft Release step uploads all the tar files generated during the Build, making it easier to scale to more variants (e.g., x86_64, aarch64, glibc, musl)
  • Modev the content of the tar file to the rood, i.e., inside the tar moved from /youki_0_4_0_linux/youki-0.3.0/youki to /youki
  • The release tar files are renamed from youki_0_4_0_linux-x86_64.tar.gz to youki-0.4.0-x86_64.tar.gz
  • Use the gh CLI command provided by GitHub to create the release instead of the third party softprops/action-gh-release

As an example of the release generated by this PR see https://github.com/jprendes/youki/releases/tag/v0.4.0

@jprendes jprendes requested review from YJDoc2 and utam0k November 21, 2023 15:51
@jprendes jprendes added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 21, 2023
@jprendes jprendes self-assigned this Nov 22, 2023
@cuisongliu
Copy link
Copy Markdown
Contributor

It seems that the structure of the uploaded tar has been changed, which may affect #2510. Should I keep the previous structure first and then make corrections in the next PR? @jprendes

@utam0k
Copy link
Copy Markdown
Member

utam0k commented Nov 26, 2023

Sorry, but could you fix the conflict with #2510?

@jprendes
Copy link
Copy Markdown
Contributor Author

Sorry, but could you fix the conflict with #2510?

Rebased!
Sorry it took so long, I've been really busy.

@jprendes
Copy link
Copy Markdown
Contributor Author

jprendes commented Dec 12, 2023

Oh, sorry, I just noticed that this also affects basic_setup.md and release_tag.sh.

Will fix that now

Edit: basic_setup.md should not be updated until we do a new release.

@jprendes jprendes removed the request for review from YJDoc2 December 12, 2023 22:42
@jprendes
Copy link
Copy Markdown
Contributor Author

@utam0k @cuisongliu PTAL :-)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 12, 2023

Codecov Report

Merging #2541 (afa98ce) into main (5115fa9) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   65.87%   65.87%           
=======================================
  Files         133      133           
  Lines       16795    16795           
=======================================
  Hits        11063    11063           
  Misses       5732     5732           

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Copy link
Copy Markdown
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k utam0k merged commit 6bd1281 into youki-dev:main Dec 16, 2023
This was referenced Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants