Add pidfile test#379
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 76.52% 76.47% -0.06%
==========================================
Files 52 52
Lines 8210 8311 +101
==========================================
+ Hits 6283 6356 +73
- Misses 1927 1955 +28 |
60 tasks
Member
|
In runtime-tools, it does create |
Collaborator
Author
|
Yes, I felt that checking it would take extra state checks which should not be relevant in an option of create command anyways, so I only added check for validating if container is created, and then the pid file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the pidfile test : which , for some reason, was failing for oci-runtime-tools in github actions. Now that I have implemented this, and it works, I am worried I have implemented it wrong 😄 😅
This test works on both local setup and GitHub actions.
Please take a look @utam0k @yihuaf