Skip to content

feat(llm): openclaw/dify 类型 SKU 创建时不填 devices #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zexi merged 1 commit into from
Mar 16, 2026
+7 −3
Merged

feat(llm): openclaw/dify 类型 SKU 创建时不填 devices #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/apis/onecloud/v1alpha1/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ var (
}
DefaultLLMSku = []llmapi.LLMSkuCreateInput{
newLLMSku("ollama-4c4g", 4, 4096, 40960, 1000, DefaultOllamaImageName, "ollama"),
newLLMSku("openclaw-4c8g", 4, 8192, 40960, 1000, DefaultOpenclawImageName, "openclaw"),
newLLMSku("openclaw-4c4g", 4, 4096, 40960, 1000, DefaultOpenclawImageName, "openclaw"),
newLLMSku("comfyui-8c16g", 8, 16384, 40960, 1000, DefaultComfyuiImageName, "comfyui"),
}
)
Expand Down Expand Up @@ -1006,7 +1006,8 @@ func newLLMSku(name string, cpu, memory, diskSize int, bandwidth int, imageId, l
LLMSKuBaseCreateInput: llmapi.LLMSKuBaseCreateInput{
SharableVirtualResourceCreateInput: apis.SharableVirtualResourceCreateInput{
SharableResourceBaseCreateInput: apis.SharableResourceBaseCreateInput{
IsPublic: &isPublic,
IsPublic: &isPublic,
PublicScope: "system",
},
VirtualResourceCreateInput: apis.VirtualResourceCreateInput{
StatusStandaloneResourceCreateInput: apis.StatusStandaloneResourceCreateInput{
Expand Down
5 changes: 4 additions & 1 deletion pkg/util/onecloud/onecloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,10 @@ func InitLLMSku(s *mcclient.ClientSession, skus []llmapi.LLMSkuCreateInput) erro
return errors.Errorf("memory is required for sku at index %d", i)
}

input.Devices = &devices
// openclaw and dify types do not require devices (no GPU)
if input.LLMType != "openclaw" && input.LLMType != "dify" {
input.Devices = &devices
}

// Ensure SKU exists
_, err := EnsureLLMSku(s, input)
Expand Down
Loading