Skip to content

feat(values): support values imports with namespacing#4592

Closed
brandtkeller wants to merge 6 commits intomainfrom
4584_values_imports
Closed

feat(values): support values imports with namespacing#4592
brandtkeller wants to merge 6 commits intomainfrom
4584_values_imports

Conversation

@brandtkeller
Copy link
Copy Markdown
Member

Description

This adds support for namespacing an imported component artifacts templates and values/schema files on import to prevent silent collisions.

Related Issue

Fixes #4584

Checklist before merging

brandtkeller and others added 5 commits February 5, 2026 11:11
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Co-authored-by: Wayne Starr <me@racer159.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller self-assigned this Feb 6, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 6, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0f410e2
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/698b665b39066f0008348064

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 30.43478% with 224 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/load/import.go 24.38% 171 Missing and 12 partials ⚠️
src/pkg/packager/load/load.go 35.89% 22 Missing and 3 partials ⚠️
src/internal/template/template.go 0.00% 6 Missing ⚠️
src/cmd/dev.go 0.00% 5 Missing ⚠️
src/pkg/packager/dev.go 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/create.go 58.16% <100.00%> (+2.24%) ⬆️
src/pkg/packager/find_images.go 57.27% <100.00%> (+0.65%) ⬆️
src/pkg/packager/inspect.go 37.84% <100.00%> (+0.87%) ⬆️
src/pkg/packager/lint.go 70.96% <100.00%> (+4.30%) ⬆️
src/pkg/packager/publish.go 65.51% <100.00%> (+0.81%) ⬆️
src/cmd/dev.go 45.94% <0.00%> (-0.27%) ⬇️
src/pkg/packager/dev.go 0.00% <0.00%> (ø)
src/internal/template/template.go 77.90% <0.00%> (-2.68%) ⬇️
src/pkg/packager/load/load.go 41.45% <35.89%> (-2.01%) ⬇️
src/pkg/packager/load/import.go 40.03% <24.38%> (-9.73%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller
Copy link
Copy Markdown
Member Author

Closing as an option we're not pursuing for values merge.

@github-project-automation github-project-automation bot moved this to Done in Zarf Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Support transient package values during component import

1 participant