fix!: only pull required layers during OCI deploy#4699
Merged
AustinAbro321 merged 22 commits intomainfrom Apr 9, 2026
Merged
Conversation
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
brandtkeller
requested changes
Apr 2, 2026
Member
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
Generally have no issues with the approach and appreciate the update.
Noticed a minor gap outside of the scope of these changes that we could include and otherwise just need to resolve CI.
Signed-off-by: Austin Abro <austinabro321@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed this issue while working on #4580. There are two issues here.
The first is that in cmd/package we weren't filtering components on load during deploy. We shouldn't filter early for interactive deploys, however we should filter early when we are confirming.
The second issue is that is that assemble layers was pulling every layer when AllLayers was given even when requested components were only a subset of the components. Also the previous API didn't have a nice way to ask for multiple layer types. For instance for skeleton packages, and the soon to be introduced "connected" packages, we won't want to pull images, so we had a isSkeleton check that pulled everything except images. Now we can request all the layers besides images.
Related Issue
Fixes #4698
Checklist before merging