test: check that store, array, and group classes are serializable #2006
Merged
jhamman merged 13 commits intozarr-developers:v3from Sep 14, 2024
Merged
test: check that store, array, and group classes are serializable #2006jhamman merged 13 commits intozarr-developers:v3from
jhamman merged 13 commits intozarr-developers:v3from
Conversation
…pickle and can be dependably roundtripped
jhamman
commented
Jul 2, 2024
d-v-b
reviewed
Jul 9, 2024
d-v-b
reviewed
Jul 9, 2024
6 tasks
Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
…nto test/serialization
d-v-b
reviewed
Aug 13, 2024
d-v-b
reviewed
Aug 13, 2024
d-v-b
reviewed
Aug 13, 2024
d-v-b
reviewed
Aug 13, 2024
d-v-b
reviewed
Aug 13, 2024
d-v-b
approved these changes
Aug 13, 2024
Contributor
d-v-b
left a comment
d-v-b
left a comment
There was a problem hiding this comment.
Some typos in the test names but otherwise this looks good to go
…nto test/serialization
…nto test/serialization
…nto test/serialization
…nto test/serialization
| assert agroup_new_attributes.attrs == attributes_new | ||
|
|
||
|
|
||
| async def test_group_members_async(store: LocalStore | MemoryStore) -> None: |
Contributor
There was a problem hiding this comment.
@jhamman was this test_group_members_async test moved somewhere, or deliberately removed?
Member
Author
There was a problem hiding this comment.
Not deliberately removed. Must have been a bad merge conflict resolution. I'll bring it back today. Sorry!
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Sep 16, 2024
* v3: fix: opening a group with unspecified format finds either v2 or v3 (zarr-developers#2183) test: check that store, array, and group classes are serializable (zarr-developers#2006) feature(store): V3 ZipStore (zarr-developers#2078) More typing fixes for tests (zarr-developers#2173) refactor: split metadata into v2 and v3 modules (zarr-developers#2163) Accept dictionaries for `store` argument (zarr-developers#2164) Simplify mypy config for tests (zarr-developers#2156) Fixed path segment duplication in open_array (zarr-developers#2167) Fixed test warnings (zarr-developers#2168) chore: update pre-commit hooks (zarr-developers#2165) Ensure that store_dict used for empty dicts (zarr-developers#2162) Bump pypa/gh-action-pypi-publish from 1.10.0 to 1.10.1 in the actions group (zarr-developers#2160)
jhamman
added a commit
to jhamman/zarr-python
that referenced
this pull request
Sep 17, 2024
6 tasks
jhamman
added a commit
that referenced
this pull request
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to insure that our store/array/group classes are serializable w/ using pickle and can be reliably roundtripped. This is important for Dask and other libraries that need to be able to share Zarr objects between processes/machines.
A necessary side effect of this work was the creation of a few additional
__eq__methods.closes #1760
TODO: