Fix: respect config when opening an existing array#2933
Open
ianhi wants to merge 5 commits intozarr-developers:mainfrom
Open
Fix: respect config when opening an existing array#2933ianhi wants to merge 5 commits intozarr-developers:mainfrom
config when opening an existing array#2933ianhi wants to merge 5 commits intozarr-developers:mainfrom
Conversation
Contributor
Author
|
Discussed with @jhamman at the dev meeting and we came to the following conclusion:
This keeps better consistency with zarr-python 2 and is more explicit in what the user is passing rather a layer of obfuscation by wrapping in |
Contributor
Author
|
Motivated by pydata/xarray#10177 cc @d-v-b |
d-v-b
reviewed
Apr 18, 2025
|
|
||
| @pytest.mark.parametrize("store", ["local"], indirect=True) | ||
| @pytest.mark.parametrize("open", ["open", "open_array"]) | ||
| def test_append_config_passed(store: LocalStore, open: str, zarr_format: ZarrFormat) -> None: |
Contributor
There was a problem hiding this comment.
Why do our existing write_empty_chunks tests not work here?
Contributor
There was a problem hiding this comment.
for context, it would probably be preferable to expand the scope of an existing test instead of adding a new one
Contributor
Author
|
Part of the fixes here ended up in #3378 but the remaining confusing with the possibliity of passing mulltiple ways of defining the same config remains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2931
Previously there were edge cases with open which would result in the
write_empty_chunksconfig was being ignored. This PR has two separate fixes.1st: for
zarr.openline 3272nd:
zarr.open_arrayrequired some config parsing as well as a change to the api ofAsyncArray.opendocs/user-guide/*.rstchanges/