Skip to content

Conversation

@hmaarrfk
Copy link

Isn't this the point?

I'm implementing a super innefficient broadcast operation for my lazy array, but then i stuck on the fact that I didn't implement a very inefficient operation for np.array_equal

related to: #3627

The result of np.broadcast... is used in the if statement a few lines above.

Do I need to go through the todo?

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Isn't this the point?

I'm implementing a super innefficient broadcast operation for my lazy
array, but then i stuck on the fact that I didn't implement a very
inefficient operation for `np.array_equal`
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Dec 18, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Dec 19, 2025

@dcherian @TomAugspurger yall might want to have a look

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. This seems to go back to #2157, and wasn't discussed there.

@hmaarrfk
Copy link
Author

after spending much too much time on this function, i find that it is likely overengineered given that it has exactly 1 usage in the codec pipeline:

12:01 $ rg all_equal
src/zarr/core/codec_pipeline.py
416:                    if not chunk_spec.config.write_empty_chunks and chunk_array.all_equal(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants