Allow Solution to be variable length to permit regtest use.#533
Draft
zancas wants to merge 3 commits intozcash:masterfrom
Draft
Allow Solution to be variable length to permit regtest use.#533zancas wants to merge 3 commits intozcash:masterfrom
zancas wants to merge 3 commits intozcash:masterfrom
Conversation
… and mainnet (cherry picked from commit 0ed485a598039004af60deccad82586d5b86c4ae)
Collaborator
|
Hi Za, I assume #505 is why this PR is needed; sorry I broke the testnet use case -- I never knew anyone used it with testnet. Let me know if I can be of any help with this PR. Taking a quick look now, it looks reasonable (changing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR.
As a note, all CI tests need to be passing and all appropriate code reviews need to be done before this PR can be merged