Skip to content

Comments

Allow Solution to be variable length to permit regtest use.#533

Draft
zancas wants to merge 3 commits intozcash:masterfrom
zingolabs:master
Draft

Allow Solution to be variable length to permit regtest use.#533
zancas wants to merge 3 commits intozcash:masterfrom
zingolabs:master

Conversation

@zancas
Copy link
Contributor

@zancas zancas commented Sep 11, 2025

Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR.

  • Relevant documentation for this PR has to be completed before the PR can be merged
  • A test plan for the PR must be documented in the PR notes and included in the test plan for the next regular release

As a note, all CI tests need to be passing and all appropriate code reviews need to be done before this PR can be merged

@zancas zancas changed the title All Solution to be variable length to permit regtest use. Allow Solution to be variable length to permit regtest use. Sep 12, 2025
@LarryRuane
Copy link
Collaborator

Hi Za, I assume #505 is why this PR is needed; sorry I broke the testnet use case -- I never knew anyone used it with testnet. Let me know if I can be of any help with this PR. Taking a quick look now, it looks reasonable (changing Solution back to a byte slice instead of a byte array).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants