Conversation
str4d
force-pushed
the
update-zaino
branch
3 times, most recently
from
eeeddb0 to
302522b
Compare
|
CI builds against latest dependency versions is currently broken by ZcashFoundation/zebra#10253. |
| } | ||
| if let syn::Meta::NameValue(doc_line) = &attr.meta | ||
| && let syn::Expr::Lit(docs) = &doc_line.value | ||
| && let syn::Lit::Str(s) = &docs.lit |
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
ZF has released updated versions, so we just need to update this PR and ensure that Zaino gets the same updates, otherwise utACK
|
No, we just needed to re-run CI once ZF had yanked the incorrect patch releases. |
|
|
||
| FROM stagex/pallet-rust@sha256:9c38bf1066dd9ad1b6a6b584974dd798c2bf798985bf82e58024fbe0515592ca AS pallet-rust | ||
| # Rust 1.91.1 | ||
| FROM stagex/pallet-rust@sha256:4062550919db682ebaeea07661551b5b89b3921e3f3a2b0bc665ddea7f6af1ca AS pallet-rust |
There was a problem hiding this comment.
I spent over two hours yesterday bisecting Zaino trying to figure out why the Docker builds were failing in rocksdb linking with missing stdlib symbols (as I assumed it was related to their Zebra dependencies), and after eliminating the entire set of Rust dependency changes, I realised that it was this Rust update itself that was causing the problem.
@antonleviathan the StageX website needs documentation for each package about how to update it. There is nothing on https://stagex.tools/packages/pallet/rust/ about it having any dependencies, so I just went to the Docker hub and found the only >=1.89 release available (1.91.1) and updated the pin to it, assuming it was self-contained. I assume the problem is that due to static linking, I also needed to bump user-abseil-cpp and/or core-user-runtime to compatible versions, but I have no idea how to figure that out (not least because all I have to go on here are SHA-256 hashes, no version information due to the pinning).
In lieu of adding such documentation to the StageX website, please open a PR adding a comment to this Dockerfile explaining how to update these dependencies correctly.
There was a problem hiding this comment.
Hmm, bumping both user-protobuf and user-abseil-cpp to the versions released the same day as the Rust 1.91.1 image did not fix the problem. I note that there was no core-user-runtime release at that same time; maybe that's the problem?
In any case, this means we cannot upgrade Zaino without breaking Docker builds, until Zaino updates to whatever Zebra crate releases include their revert to MSRV of 1.85.
There was a problem hiding this comment.
Required to update `zebra-state`.
|
Force-pushed to rebase on latest |
|
Force-pushed to update Zaino to its latest revision. |
5 participants
Requires bumping MSRV to 1.89 due to
zebra-state.Part of COR-307.