This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fixed class generator ignoring use aliases for extended class#144
Closed
allcode wants to merge 1 commit intozendframework:developfrom
Closed
Fixed class generator ignoring use aliases for extended class#144allcode wants to merge 1 commit intozendframework:developfrom
allcode wants to merge 1 commit intozendframework:developfrom
Conversation
… extended class The class generator will now use the alias of a use statement if it matches the extended class or its namespace.
54e2bc5 to
d45d476
Compare
allcode
added a commit
to allcode/xsd2php
that referenced
this pull request
Nov 14, 2017
- Removed default mixed parameter type, as zend code generator will now see mixed as a class name. - Removed aliasing of extended class when extended class name is the same as the generated class; zend code generator currently has a bug with aliases (see pull request for fix: zendframework/zend-code#144).
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2018
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2018
Member
|
Thanks, @allcode! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for the class generator when using a use alias for the extended
class.
Bug explanation
Before this patch, the class generator would ignore all use aliases. This resulted
in an incorrect extends class. For example:
would result in:
When using an FQCN for the extended class, it would ignore the use statement:
would result in:
Fix explanation
This PR fixes the ClassGenerator by checking whether the extended class matches
one of the use statements.
It supports the following varieties:
Using an alias as the extended class
will result in:
Using an alias of the extended class namespace
will result in:
Using an FQCN as the extended class
The class generator will replace the extended class with its alias, if an exact use
statement match is defined.
will result in:
The class generator will replace the namespace of the extended class with its alias,
if an exact use statement match is defined.
will result in: