recursively set indentations for child arrays#164
recursively set indentations for child arrays#164Ocramius merged 8 commits intozendframework:developfrom
Conversation
hxss
left a comment
hxss
left a comment
There was a problem hiding this comment.
sorry I dont have php7 on this machine, so I just added methods in same style.
| * | ||
| * @return array | ||
| */ | ||
| public function complexArrayWCustomIndent() |
| /** | ||
| * Data provider for testPropertyDefaultValueCanHandleComplexArrayWCustomIndentOfTypes test | ||
| * | ||
| * @return array |
| * @param array $value | ||
| * @param string $expected | ||
| */ | ||
| public function testPropertyDefaultValueCanHandleComplexArrayWCustomIndentOfTypes($type, array $value, $expected) |
There was a problem hiding this comment.
Please add type declarations to the parameters: drop them from the docblock
hxss
left a comment
hxss
left a comment
There was a problem hiding this comment.
I was copy that code from complexArray test.
hxss
left a comment
hxss
left a comment
There was a problem hiding this comment.
sorry, forgot : void
|
Check the failures, something is not working as expected: https://travis-ci.org/zendframework/zend-code/jobs/445104487#L653 |
hxss
left a comment
hxss
left a comment
There was a problem hiding this comment.
sublime trim_trailing_white_space_on_save on 280 line :)
|
CS checks still fail: https://travis-ci.org/zendframework/zend-code/jobs/445361931#L675-L744 |
|
lol. TABS > spaces |
|
Last one: https://travis-ci.org/zendframework/zend-code/jobs/445367598#L675-L680 Maybe one level of nesting less would suffice 👍 |
3 participants
PR for #163
I was use auto generated complex arrays with personal data for tests, so I cant publish it.