This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix generation of non-optional object parameters that can be null.#95
Merged
Ocramius merged 1 commit intozendframework:masterfrom Oct 24, 2016
Merged
Fix generation of non-optional object parameters that can be null.#95Ocramius merged 1 commit intozendframework:masterfrom
Ocramius merged 1 commit intozendframework:masterfrom
Conversation
Example: function foo(\stdClass $a = null, $b)
Contributor
adamlundrigan
left a comment
adamlundrigan
left a comment
There was a problem hiding this comment.
Makes sense to me but I'll defer to @Ocramius
Ocramius
added a commit
that referenced
this pull request
Oct 24, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following example:
By generating a method from the ReflectionMethod of the given code above, the generated code did not consider the default value from $a. This has the effect, that one cannot pass null into that variable any more.
This PR fixes this. See also Ocramius/ProxyManager#337