Fix bug that the button in header disappears when canceling the search#16
Closed
jaywhj wants to merge 5 commits intozensical:masterfrom
Closed
Fix bug that the button in header disappears when canceling the search#16jaywhj wants to merge 5 commits intozensical:masterfrom
jaywhj wants to merge 5 commits intozensical:masterfrom
Conversation
Signed-off-by: Aaron <junewhj@qq.com>
Signed-off-by: Aaron <junewhj@qq.com>
Signed-off-by: Aaron <junewhj@qq.com>
Signed-off-by: Aaron <junewhj@qq.com>
Fix bug, on mobile, after switching the classic theme and clicking the search button and then canceling the search, the language selection box and theme switching button in the header will disappear, and at the same time the page is stuck and can't be scrolled, recurring every two clicks (odd numbered clicks) Signed-off-by: Aaron <junewhj@qq.com>
|
All commits verified and signed off. |
squidfunk
added a commit
that referenced
this pull request
Dec 18, 2025
…c theme (#16) Signed-off-by: squidfunk <martin.donath@squidfunk.com>
Member
|
Thanks for the PR. The fix was not correct though, it just needed to be fixed in CSS. Fixed in fa23b1c. |
squidfunk
added a commit
that referenced
this pull request
Dec 18, 2025
* refactor: use `px2rem` for `kbd` styles Signed-off-by: squidfunk <martin.donath@squidfunk.com> * fix: instant navigation doesn't trigger on keyboard shortcuts `p` and `n` (#10) Signed-off-by: squidfunk <martin.donath@squidfunk.com> * fix: header buttons disappear on mobile when opening search in classic theme (#16) Signed-off-by: squidfunk <martin.donath@squidfunk.com> * fix: search can receive keyboard input after being closed (#10) Signed-off-by: squidfunk <martin.donath@squidfunk.com> * fix: language selector escapes viewport when too wide on mobile (#14) Signed-off-by: squidfunk <martin.donath@squidfunk.com> Co-authored-by: jaywhj <7008992+jaywhj@users.noreply.github.com> * fix: git repository not shown in sidebar on mobile in modern theme (#6) Signed-off-by: squidfunk <martin.donath@squidfunk.com> * feature: add third-party licenses to distribution files (#1) Signed-off-by: squidfunk <martin.donath@squidfunk.com> --------- Signed-off-by: squidfunk <martin.donath@squidfunk.com> Co-authored-by: jaywhj <7008992+jaywhj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug, on mobile, after switching the classic theme and clicking the search button and then canceling the search, the language selection box and theme switching button in the header will disappear, and at the same time the page is stuck and can't be scrolled, recurring every two clicks (odd numbered clicks)