drivers: acp: add TDM DAI and DMA support for native Zephyr drivers for AMD ACP 7.0#108314
drivers: acp: add TDM DAI and DMA support for native Zephyr drivers for AMD ACP 7.0#108314Sivasubramanian678 wants to merge 2 commits into
Conversation
zephyrbot
added
area: Boards/SoCs
area: DAI
area: DMA
zephyrbot
requested review from
JarmouniA,
abonislawski,
andyross,
ceolin,
dbaluta,
dcpleung,
iuliana-prodan,
kv2019i,
lgirdwood,
mcuxted,
nashif,
serhiy-katsyuba-intel and
teburd
|
@kv2019i Could you please review this PR and let me know if there are any further updates or improvements needed? |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Mostly looks good. A couple of smaller comments.
| LOG_DBG("start: idx=%d dir=%d", tdm_inst, chan->direction); | ||
|
|
||
| switch (tdm_inst) { | ||
| case 0: /* HS */ |
There was a problem hiding this comment.
Minor: These magic values keep repeating in code (and also in DAI drivers), so a common defined would be nice. But not a blocker, these are commented systematically.
| @@ -0,0 +1,18 @@ | |||
| # SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors | |||
There was a problem hiding this comment.
I think this should go to dts/bindings/dma/ as this binding for the DMA driver
There was a problem hiding this comment.
Thanks @kv2019i for pointing this out. The requested changes have been made.
|
+1 for this PR from ACP hardware and software side |
| @@ -0,0 +1,637 @@ | |||
| /* SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors */ | |||
| /* | |||
| * Copyright (c) 2026 AMD | |||
There was a problem hiding this comment.
this is really weird formatting and wording - if you feel strongly about having AMD copyright then please use just that (and not "Copyright The Zephyr Project Contributors") and use SPDX-FileCopyrightText tag
Please fix everywhere
| * Copyright (c) 2026 AMD | |
| /** | |
| * SPDX-FileCopyrightText: Copyright (c) 2026 AMD |
Add TDM DAI driver and ACP 7.0 register definitions for AMD Audio Co-Processor. This includes: - TDM DAI driver (tdm_dai.c, tdm_dai.h) with support for I2S format - ACP 7.0 chip register definitions and offset mappings - Device tree bindings and nodes for TDM DAI instances - Kconfig and CMake build integration Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com> Co-authored-by: DineshKumar Kalva <DineshKumar.Kalva@amd.com>
Add TDM DMA driver for AMD Audio Co-Processor 7.0. This includes: - DMA driver (dma_acp_tdm.c) with support for memory-to-device and device-to-memory transfers using ACP DMA engine - Device tree bindings and node for ACP TDM DMA controller - Kconfig and CMake build integration Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com> Co-authored-by: DineshKumar Kalva <DineshKumar.Kalva@amd.com>
Sivasubramanian678
dismissed stale reviews from abonislawski and kv2019i
via
5d7d76e
|
|
@kv2019i , @abonislawski Hi, could you please review the PR and let me know if any changes are required? Thank you! |
We need support here as our delivery/release is waiting and waiting in queue to raise other PR's. |
6 participants
This PR adds native Zephyr support for AMD Audio Co-Processor (ACP) version 7.0 for handling TDM IO.