Migrate bin/openapi to Symfony Console#1977
Merged
DerManoMann merged 9 commits intozircote:masterfrom Mar 30, 2026
Merged
Conversation
yceruto
force-pushed
the
sf_console
branch
4 times, most recently
from
b2fde19 to
3c34378
Compare
DerManoMann
requested changes
Mar 16, 2026
Collaborator
DerManoMann
left a comment
DerManoMann
left a comment
There was a problem hiding this comment.
Some minor bits, but looking very nice already!
yceruto
commented
Mar 16, 2026
Contributor
Author
|
It seems cs failures are unrelated to this changes |
Collaborator
|
Looks like I might need to update master with some changes for the latest cs-fixer :/ Edit: Although locally it passes - hmmm. |
Collaborator
|
Eh, its rector; trips me up every time! |
Collaborator
|
@yceruto I've updated |
# Conflicts: # src/Loggers/ConsoleLogger.php
…ing and integrate SymfonyStyle for enhanced user feedback
… for format handling and improve option descriptions
… and simplify path exclusion handling
Collaborator
|
Looking pretty good. I am just not sure I like the double output from the error listener, for example Is the error listener strictly needed? Seems the tests (at least) pass even without it. |
Contributor
Author
|
Sure, it's not required. I've removed it. |
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-1977-to-5.x
git worktree add --checkout .worktree/backport-1977-to-5.x backport-1977-to-5.x
cd .worktree/backport-1977-to-5.x
git reset --hard HEAD^
git cherry-pick -x ce85d8ef2d1e87db5bf31bbedc915b59c927f56f baccd77d5818712bb1666b1c568996e6be863ee7 f18eaf2e24ef1f84798834f5af7e0cdde26d5d55 d7ceb1e19bb4a0139c420cbf6457733b8fabfcd7 734d780f9efe42938b656e1b80c8ca9bf2bcaa27 644fa4d4ac6f67ce8acc33136851991e6e42ac59 c83b434ec0f075ab751555e4aeed3dfb6c24bfc6 b4f97be7ba8f4ffb5f1cc17fc431901585d7c3c2 06aebb86dc9ace17c96744b4d3b019385210149f
git push --force-with-lease |
3 tasks
Collaborator
|
Thanks @yceruto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
bin/openapifrom a 270-line standalone script with manual argument parsing to a Symfony Console application, leveraging modern Symfony 8.0 features:#[AsCommand]attribute for command metadata#[MapInput]with aGenerateInputDTO for declarative input definition#[Argument]/#[Option]attributes on DTO properties__invoke()ConsoleLoggerwith Symfony'sConsoleLoggerSymfonyStylefor user-facing output (defaults, bootstrap info)All existing CLI behavior is preserved (output format, exit codes, processor management, comma-separated exclude deprecation warning).
Type of Change
Related Issues
Part of #1953