Restore possibility to change keep_session param.#40
Merged
Conversation
Before version 1.2 it was possible to change the value of `keep_session` for certain tests. We used `keep_session=True` to ease unittests which are not forced to re-fetch objects from database after a commit. On the other hand selenium tests should behave more like an actual web server which does not keep the session. So we switched to `keep_session=False` for some tests with code like this: https://github.com/gocept/risclog.sqlalchemy/blob/44fe2494337b41e0bc3d5602ebbd7493918d841d/src/risclog/sqlalchemy/fixtures.py#L6 This is no longer possible since zope.sqlalchemy 1.2. With this commit the ability to access the `ZopeTransactionEvents` instance is restored.
Member
Author
|
Could this be a possible solution where I should invest to fix the tests or does anyone think this is a bad idea. |
mgedmin
reviewed
Dec 9, 2019
Member
mgedmin
left a comment
mgedmin
left a comment
There was a problem hiding this comment.
LGTM, but please document the return value in the docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before version 1.2 it was possible to change the value of
keep_sessionfor certain tests.We used
keep_session=Trueto ease unittests which are not forced to re-fetch objects from database after a commit. On the other hand selenium tests should behave more like an actual web server which does not keep the session.So we switched to
keep_session=Falsefor some tests with code like this:https://github.com/gocept/risclog.sqlalchemy/blob/44fe2494337b41e0bc3d5602ebbd7493918d841d/src/risclog/sqlalchemy/fixtures.py#L6
This is no longer possible since zope.sqlalchemy 1.2.
With this commit the ability to access the
ZopeTransactionEventsinstance is restored.