Issue 67

[silenius]

This is a fix for #67 with changes from #66 included

Close #66.

[icemac]

All tests are breaking on GHA. On master at least Python 3.6+ and lint are successful. Could you please have a look?

[silenius]

it should be OK for >3.5 (tests are broken for < 3.6 (as you noticed in #69))

[icemac]

@silenius The lint checks still fail. For Python < 3.6 I am preparing a fix at #70.

[icemac]

#70 is now merged, I added the changes to this PR, too.

[icemac]

Thank you for your contribution.

According to the contributing policies of the zopefoundation organization you need to sign a contributor agreement before any non-trivial change can be merged. For details please consult the Contributing guidelines for zopefoundation projects.

[silenius]

Thank you for looking at this. I'll check the contributor agreement document as soon as I have a little time and keep you updated..

[silenius]

I've completed and sent the PDF document to agreements@plone.org

[icemac]

LGTM.

In zopefoundation repositories the policy is that the creator of the PR merges it, to prove having signed the contributor agreement.

[silenius]

✔️

[icemac]

I am going to write a change log entry and to cut a release now.

[icemac]

I just released https://pypi.org/project/zope.sqlalchemy/1.5/