Fix the rotation of aero force vector to body frame#3
Merged
zuorenchen merged 1 commit intomasterfrom Mar 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect vector rotation in GenericSurface.compute_forces_and_moments().
Here, we want to represent the black
L,D,Qvectors in the blue body frame.The M_BA matrix should be direction cosine matrix (DCM), however it is given in vector rotation matrices. Vector rotation matrices rotate the vector without changing/rotating reference frame.
Current implementation rotates the force vectors to match body axis, but results are however presented in aero frame.
If it is intended to use rotation matrix instead of DCM, the rotation should be:
Q,L,Dvectors matching+X,-Y,-Zin body frame (i.e. Vector([side, -lift, -drag]) )-alphaon X axis andbetaon Y axis.Q,L,Dvectors and presented in body frameAnother POV:
-alphaon X axis andbetaon Y axis.