Skip to content

chore: Drop macOs-13 on Azure Pipelines, fix parameter name for pyinstaller template#1338

Merged
Czaki merged 2 commits intodevelopfrom
fix-runners
Dec 15, 2025
Merged

chore: Drop macOs-13 on Azure Pipelines, fix parameter name for pyinstaller template#1338
Czaki merged 2 commits intodevelopfrom
fix-runners

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Dec 15, 2025

Summary by Sourcery

CI:

  • Switch Azure Pipelines macOS jobs from the macos-13 image to macos-14 and consolidate the macOS matrix entries.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline macOS build and test configurations to use a newer macOS image.
    • Standardized the test invocation parameter across pipeline templates to ensure consistent test execution.

✏️ Tip: You can customize this high-level summary in your review settings.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Azure Pipelines to use macOS 14 instead of macOS 13 and simplifies the macOS test matrix by consolidating to a single macOS-14 configuration.

File-Level Changes

Change Details Files
Switch CI build stage macOS image from macOS-13 to macOS-14.
  • Update the macOS matrix entry to reference the macOS-14 hosted image.
  • Keep the existing windows-2022 image configuration unchanged.
azure-pipelines.yml
Consolidate test matrix to a single macOS-14 configuration and remove the separate macOS-13/macos_arm entries.
  • Remove the macOS-13 test matrix entry and its associated test_path configuration.
  • Remove the separate macos_arm matrix key, using macOS-14 as the unified macOS entry with its test_path.
  • Retain the windows test configuration as-is.
azure-pipelines.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated Azure Pipelines CI: macOS runner image bumped from macos-13 to macos-14 and pipeline parameter/variable renamed from test_path to test_command across jobs and templates.

Changes

Cohort / File(s) Change Summary
Pipeline matrix & image updates
azure-pipelines.yml
Replaced macos-13 with macos-14 in Tests_other and Builds matrices; consolidated macOS matrix entries to use macos-14.
PyInstaller pipeline parameter rename
.azure-pipelines/pyinstaller.yaml, azure-pipelines.yml
Renamed parameter test_pathtest_command and updated all references/usages (job variables, template parameter passing, script step inputs).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are configuration-level and consistent but span multiple CI files.
  • Review attention:
    • .azure-pipelines/pyinstaller.yaml parameter declaration and usages.
    • All places in azure-pipelines.yml that pass or expect the parameter (matrix entries, job variables).
    • Ensure no remaining test_path occurrences and that test_command is correctly consumed by scripts.

Possibly related PRs

Poem

🐰
A hop, a tweak, the runners gleam,
From thirteen up to fourteen's beam.
I swapped the path for a command so neat,
CI hums along on nimble feet.
—The Pipeline Rabbit 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the two main changes: updating macOS from version 13 to 14, and fixing the parameter name in the pyinstaller template.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The macos_arm matrix entry has been removed and merged into macos; if you still need to distinguish Intel vs ARM jobs in downstream logic (e.g., conditions based on matrix.key), consider keeping distinct matrix keys or renaming this one to reflect its architecture explicitly.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `macos_arm` matrix entry has been removed and merged into `macos`; if you still need to distinguish Intel vs ARM jobs in downstream logic (e.g., conditions based on `matrix.key`), consider keeping distinct matrix keys or renaming this one to reflect its architecture explicitly.

## Individual Comments

### Comment 1
<location> `azure-pipelines.yml:180` </location>
<code_context>
           matrix:
             macos:
-              imageName: 'macos-13'
-              test_path: dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test
-            macos_arm:
               imageName: 'macos-14'
</code_context>

<issue_to_address>
**issue (bug_risk):** The `test_path` value looks malformed and may not expand to the intended path(s).

The string currently has a space in `PartSeg _test` and repeats the same path three times with `||`, so it will be interpreted as one malformed shell expression rather than multiple paths. Please verify the actual directory name(s) and adjust this to valid, distinct, and properly quoted paths if you intend alternatives (or remove `||` if not needed).
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

test_path: dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test
macos_arm:
imageName: 'macos-14'
test_path: dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The test_path value looks malformed and may not expand to the intended path(s).

The string currently has a space in PartSeg _test and repeats the same path three times with ||, so it will be interpreted as one malformed shell expression rather than multiple paths. Please verify the actual directory name(s) and adjust this to valid, distinct, and properly quoted paths if you intend alternatives (or remove || if not needed).

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (f20834a) to head (01ece9d).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1338   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files          210      210           
  Lines        33232    33232           
========================================
  Hits         30964    30964           
  Misses        2268     2268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki changed the title chore: Drop macos-13 on Azure Pipelines chore: Drop macOs-13 on Azure Pipelines Dec 15, 2025
@Czaki Czaki added the skip check PR title skip spellcheking PR title label Dec 15, 2025
@Czaki
Copy link
Collaborator Author

Czaki commented Dec 15, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Czaki Czaki added this to the 0.16.5 milestone Dec 15, 2025
@Czaki Czaki changed the title chore: Drop macOs-13 on Azure Pipelines chore: Drop macOs-13 on Azure Pipelines, fix parameter name for pyinstaller template Dec 15, 2025
@sonarqubecloud
Copy link

@Czaki Czaki merged commit f4e594e into develop Dec 15, 2025
60 of 61 checks passed
@Czaki Czaki deleted the fix-runners branch December 15, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip check PR title skip spellcheking PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments