chore: Drop macOs-13 on Azure Pipelines, fix parameter name for pyinstaller template#1338
chore: Drop macOs-13 on Azure Pipelines, fix parameter name for pyinstaller template#1338
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Azure Pipelines to use macOS 14 instead of macOS 13 and simplifies the macOS test matrix by consolidating to a single macOS-14 configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated Azure Pipelines CI: macOS runner image bumped from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The
macos_armmatrix entry has been removed and merged intomacos; if you still need to distinguish Intel vs ARM jobs in downstream logic (e.g., conditions based onmatrix.key), consider keeping distinct matrix keys or renaming this one to reflect its architecture explicitly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `macos_arm` matrix entry has been removed and merged into `macos`; if you still need to distinguish Intel vs ARM jobs in downstream logic (e.g., conditions based on `matrix.key`), consider keeping distinct matrix keys or renaming this one to reflect its architecture explicitly.
## Individual Comments
### Comment 1
<location> `azure-pipelines.yml:180` </location>
<code_context>
matrix:
macos:
- imageName: 'macos-13'
- test_path: dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test
- macos_arm:
imageName: 'macos-14'
</code_context>
<issue_to_address>
**issue (bug_risk):** The `test_path` value looks malformed and may not expand to the intended path(s).
The string currently has a space in `PartSeg _test` and repeats the same path three times with `||`, so it will be interpreted as one malformed shell expression rather than multiple paths. Please verify the actual directory name(s) and adjust this to valid, distinct, and properly quoted paths if you intend alternatives (or remove `||` if not needed).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
azure-pipelines.yml
Outdated
| test_path: dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test | ||
| macos_arm: | ||
| imageName: 'macos-14' | ||
| test_path: dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test || dist/PartSeg/PartSeg _test |
There was a problem hiding this comment.
issue (bug_risk): The test_path value looks malformed and may not expand to the intended path(s).
The string currently has a space in PartSeg _test and repeats the same path three times with ||, so it will be interpreted as one malformed shell expression rather than multiple paths. Please verify the actual directory name(s) and adjust this to valid, distinct, and properly quoted paths if you intend alternatives (or remove || if not needed).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1338 +/- ##
========================================
Coverage 93.17% 93.17%
========================================
Files 210 210
Lines 33232 33232
========================================
Hits 30964 30964
Misses 2268 2268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|



Summary by Sourcery
CI:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.