Adsk Contrib - Adding the new cg and studio configs (issue #1999)#2039
Conversation
… configs. - Added new configs cg-config-v2.2.0_aces-v1.3_ocio-v2.4.ocio and studio-config-v2.2.0_aces-v1.3_ocio-v2.4.ocio - Made default config cg-config-v2.2.0_aces-v1.3_ocio-v2.4 - Updated the tests accordingly. TODO: Some documents such as aces_cg.rst and aces_studio.srt need to be updated. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
doug-walker
requested review from
michdolan and
zachlewis
and removed request for
doug-walker
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
|
Related question: The list of builtin configs is growing, is there a deprecation/removal plan? |
|
@KelSolaar , I'm guessing you're asking that question due to a concern over the increase in size it adds to the library? The goal is to improve the system so that it only implements the deltas between configs rather than generating each from scratch. In the nanoColor branch we have a way of generating the built-in configs via code (starting from the YAML files you provided). Currently this simply regenerates each config from the YAML, but this approach could be extended to avoid a significant increase in size by only implementing the changes from one version to the next. |
zachlewis
left a comment
zachlewis
left a comment
There was a problem hiding this comment.
Dunno if I love the idea of a color space called "CIE XYZ-D65 - Scene-referred", but it does make more sense in the context of the Display-referred equivalent also existing.
This has no doubt come up in the config meetings, but are we absolutely certain we want to expose the Scene-referred XYZ D65, and not the Display-referred? Maybe it's just me, but I've been using XYZ D65 to encode display-referred EXRs, to differentiate them from scene-referred RGB EXRs. (e.g., when one department is working on supers and graphic elements "on top of the LUT", while others are working scene-referred, "beneath the LUT").
Either way, these builtin configs look great to me!
|
@zachlewis , thanks for the feedback. Let's discuss removing "CIE XYZ-D65 - Display-referred" from the inactive list at the TSC meeting on Monday. |
-- lin_displayp3_scene --> lin_p3d65_scene -- srgb_displayp3_scene --> srgb_p3d65_scene Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
|
Following the discussion at the TSC meeting today, we decided to add the color space "CIE XYZ-D65 - Scene-referred" to the inactive list. I logged this separately here. To recap, the group agreed that this is more for use via the API and is not something that should be exposed in artist menus. @zachlewis , thanks for starting the discussion. I pushed a commit to implement the change. |
I realised that I did put it first on my side, with the idea that we go from Scene to Display. |
…twareFoundation#1999) (AcademySoftwareFoundation#2039) * For issue AcademySoftwareFoundation#1999 adding the new cg and studio configs. - Added new configs cg-config-v2.2.0_aces-v1.3_ocio-v2.4.ocio and studio-config-v2.2.0_aces-v1.3_ocio-v2.4.ocio - Made default config cg-config-v2.2.0_aces-v1.3_ocio-v2.4 - Updated the tests accordingly. TODO: Some documents such as aces_cg.rst and aces_studio.srt need to be updated. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * - minor white-space fixes. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * renaming P3 display scene referred aliases: -- lin_displayp3_scene --> lin_p3d65_scene -- srgb_displayp3_scene --> srgb_p3d65_scene Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> * Make CIE-XYZ Scene-referred inactive Signed-off-by: Doug Walker <doug.walker@autodesk.com> --------- Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com> Signed-off-by: Doug Walker <doug.walker@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Chris Nash <chris.nash@disguise.one>
4 participants
For issue #1999 adding the new cg and studio configs.
TODO: Some documents such as aces_cg.rst and aces_studio.srt need to be updated.