Skip to content
This repository was archived by the owner on Dec 22, 2025. It is now read-only.

Moves integration tests to E2E test project#491

Merged
spygi merged 12 commits intodevfrom
feature/473-rename-int-tests-e2e
Oct 14, 2021
Merged

Moves integration tests to E2E test project#491
spygi merged 12 commits intodevfrom
feature/473-rename-int-tests-e2e

Conversation

@spygi
Copy link
Contributor

@spygi spygi commented Oct 11, 2021 •
edited
Loading

PR for issue #473

How is this addressed

  • Project moved under Tests/ and renamed to E2E
    • Namespace follows folder structure
  • XunitRetryHelper project merged into it (is only used from the E2E tests)
    • Kept separate folder/namespace
  • CI adjusted as needed
    • Test results moved to their own folders for unit and E2E tests

Out of scope

@spygi spygi marked this pull request as draft October 11, 2021 15:28
@spygi spygi changed the title Moves integration tests to E2E test project Moves integration tests to E2E test project 👷‍♀️👷‍♀️ WIP Oct 11, 2021
@spygi spygi added the fullci Run full continuous integration label Oct 11, 2021
@spygi spygi closed this Oct 11, 2021
@spygi spygi reopened this Oct 11, 2021
@spygi spygi marked this pull request as ready for review October 11, 2021 15:36
@spygi spygi closed this Oct 11, 2021
@spygi spygi reopened this Oct 11, 2021
@spygi spygi added this to the 🏃 S01E01 milestone Oct 11, 2021
@spygi spygi temporarily deployed to CI October 11, 2021 15:38 Inactive
@spygi spygi marked this pull request as draft October 11, 2021 15:39
spygi added 2 commits October 11, 2021 18:18
@spygi
Renames appsettings to e2etests for consistency
8c6a95a
@spygi
Merge remote-tracking branch 'origin/dev' into feature/473-rename-int…
abfbc58 
…-tests-e2e

# Conflicts:
#	.github/workflows/ci.yaml
#	LoRaEngine/test/LoRaWan.IntegrationTest/appsettings.json
#	LoRaEngine/test/XunitRetryHelper/XunitRetryHelper.csproj
@spygi spygi temporarily deployed to CI October 12, 2021 09:46 Inactive
@spygi spygi changed the title Moves integration tests to E2E test project 👷‍♀️👷‍♀️ WIP Moves integration tests to E2E test project Oct 12, 2021
@spygi spygi temporarily deployed to CI October 12, 2021 09:52 Inactive
@spygi spygi marked this pull request as ready for review October 12, 2021 09:53
@spygi spygi mentioned this pull request Oct 12, 2021
Closed
@spygi spygi removed the fullci Run full continuous integration label Oct 12, 2021
@spygi spygi closed this Oct 12, 2021
@spygi spygi reopened this Oct 12, 2021
bastbu
bastbu approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@bastbu bastbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍.

@spygi spygi mentioned this pull request Oct 13, 2021
Merged
@spygi spygi merged commit 6d8fd49 into dev Oct 14, 2021
@spygi spygi deleted the feature/473-rename-int-tests-e2e branch October 14, 2021 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bastbu bastbu bastbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

S01E01

Development

Successfully merging this pull request may close these issues.

2 participants

@spygi @bastbu