New integration tests project

[spygi]

PR for issue #506

• New integration tests project that contains a couple of test classes that were part of unit tests previously.
  • The classes test from the Facade test project, test against a Docker redis instance. In order to have them passing make sure to docker start redis6001 and redis6002 also locally.
  • The NetworkServer test project contained some other integration tests that had "E2E" or "End2End" in their names. Those were moved and the names were adjusted accordingly.

Validation

• Tests take about 1:30 min locally and succeed both on the CI and locally.
• Report is generated (but not checked in) as cobertura.xml in the Tests/Integration/ folder
• The test CloudToDeviceMessageSizeLimitShouldAcceptTests.Should_Accept fails on CI:
  • Tried with the some dotnet CLI version as the runners locally (5.0.401) but tests pass locally. For now disabled in order to continue with the refactoring and will be addressed in Re-enable CloudToDeviceMessageSizeLimitShouldAcceptTests.Should_Accept test  #562
• Regarding codecoverage looking as dropping: we are currently reporting only coverage from 1 repo -> will be addressed in [bug] Not all test projects are generating coverage reports #558

[bastbu]

What is the purpose of the LoRaWan.IntegrationTest, now that we have LoRaWan.Tests.Integration project? Should we merge the two projects?

[bastbu]

The PR looks good to me and is a good step from the previous setup. I especially like that the unit tests are much quicker to run and that there's a clearer separation between the different types of tests.

I do not see a reason to keep two integration test projects (LoRaWan.IntegrationTest and LoRaWan.Tests.Integration) and would suggest to merge these before merging the PR

[spygi]

What is the purpose of the LoRaWan.IntegrationTest, now that we have LoRaWan.Tests.Integration project? Should we merge the two projects?

The other PR #491 removes the LoRaWan.IntegrationTest project and moves it's contents into the E2E folder. My plan is to merge first #491 and then this PR here so at the end there will be only 1 Integration tests project.

[codecov-commenter]

Codecov Report

Merging #508 (e96a72d) into dev (d5178ba) will decrease coverage by 8.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #508      +/-   ##
==========================================
- Coverage   62.37%   54.11%   -8.27%     
==========================================
  Files         131      153      +22     
  Lines        5534     5714     +180     
==========================================
- Hits         3452     3092     -360     
- Misses       2082     2622     +540     

Impacted Files	Coverage Δ
LoRaEngine/LoraKeysManagerFacade/HttpUtilities.cs	0.00% <ø> (ø)
...gine/LoraKeysManagerFacade/SearchDeviceByDevEUI.cs	0.00% <ø> (ø)
...RaEngine/LoraKeysManagerFacade/VersionValidator.cs	0.00% <ø> (ø)
...an.NetworkServer/ServiceFacadeHttpClientHandler.cs	0.00% <ø> (-88.00%)	⬇️
...n.NetworkServer/ServiceFacadeHttpClientProvider.cs	0.00% <ø> (ø)
...etworkSrvModule/LoRaWan.NetworkServer/UdpServer.cs	0.00% <ø> (ø)
...NetworkSrvModule/LoraTools/CommonAPI/ApiVersion.cs	0.00% <ø> (ø)
...SrvModule/LoraTools/ADR/LoRaADRStrategyProvider.cs	0.00% <0.00%> (-100.00%)	⬇️
...n.NetworkServer/ExternalGatewayLoRaRequestQueue.cs	0.00% <0.00%> (-100.00%)	⬇️
... and 94 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339dd6c...e96a72d. Read the comment docs.