This repository was archived by the owner on Dec 22, 2025. It is now read-only.
Fix path to Directory.Build.props in solution file#559
Merged
Conversation
danigian
approved these changes
Oct 18, 2021
spygi
pushed a commit
that referenced
this pull request
Oct 18, 2021
spygi
added a commit
that referenced
this pull request
Oct 19, 2021
* Moves facade tests against redis in int-tests * More consistent casing and editorconfig settings * Fixes CI with new integration test project. * Moves ApiVersion to LoRaTools as it's shared. * Uses agreed way to expose internals to tests. * Removes whitespace diff. * Moves integration tests to the newly created proj * Moves more integration tests to the int-test-proj. * Fixes yaml syntax. * Fixes path. * Corrects casing of project. * Merge remote-tracking branch 'origin/dev' into feature/473-rename-int-tests-e2e * Uses common versions for package references. * Fixes compliation errors. * Renames tests to not include E2E in their names nor underscores. "Integration" is used in the name only when required to avoid name "collisions" * Reuses variables. * Ensures integration tests are covered in codecov * Fixes dotnetdocker version. * Fixes multiple issues with tests: - Ensures coverage report is generated for integration tests. - Excludes Tests from coverage. - Fixes DotNet.509 reference * Uses variable for package version. * Bump Microsoft.Azure.EventHubs from 4.2.0 to 4.3.2 in /LoRaEngine (#555) Bumps [Microsoft.Azure.EventHubs](https://github.com/Azure/azure-sdk-for-net) from 4.2.0 to 4.3.2. - [Release notes](https://github.com/Azure/azure-sdk-for-net/releases) - [Commits](Azure/azure-sdk-for-net@Microsoft.Azure.EventHubs_4.2.0...Microsoft.Azure.EventHubs_4.3.2) --- updated-dependencies: - dependency-name: Microsoft.Azure.EventHubs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix path to "Directory.Build.props" in solution file (#559) * Merge fixup. * Skips test that fails on CI -> will be solved with #562 * - more consinstent project guids - orders consistently tests * Not required suppression * Adds issue tracking Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Atif Aziz <code@raboof.com>
spygi
added a commit
that referenced
this pull request
Oct 19, 2021
* Moves facade tests against redis in int-tests * More consistent casing and editorconfig settings * Fixes CI with new integration test project. * Moves ApiVersion to LoRaTools as it's shared. * Uses agreed way to expose internals to tests. * Removes whitespace diff. * Moves integration tests to the newly created proj * Moves more integration tests to the int-test-proj. * Fixes yaml syntax. * Fixes path. * Corrects casing of project. * Merge remote-tracking branch 'origin/dev' into feature/473-rename-int-tests-e2e * Uses common versions for package references. * Fixes compliation errors. * Renames tests to not include E2E in their names nor underscores. "Integration" is used in the name only when required to avoid name "collisions" * Reuses variables. * Ensures integration tests are covered in codecov * Fixes dotnetdocker version. * Fixes multiple issues with tests: - Ensures coverage report is generated for integration tests. - Excludes Tests from coverage. - Fixes DotNet.509 reference * Uses variable for package version. * Bump Microsoft.Azure.EventHubs from 4.2.0 to 4.3.2 in /LoRaEngine (#555) Bumps [Microsoft.Azure.EventHubs](https://github.com/Azure/azure-sdk-for-net) from 4.2.0 to 4.3.2. - [Release notes](https://github.com/Azure/azure-sdk-for-net/releases) - [Commits](Azure/azure-sdk-for-net@Microsoft.Azure.EventHubs_4.2.0...Microsoft.Azure.EventHubs_4.3.2) --- updated-dependencies: - dependency-name: Microsoft.Azure.EventHubs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix path to "Directory.Build.props" in solution file (#559) * Merge fixup. * Skips test that fails on CI -> will be solved with #562 * Creates new Unit project that contains LoRaWanTest * Removes LorakeysManagerFacade.Test proj. * Moves tests to facade folder. * Moves tests to LoRaWanTests folder. * Fixes compliation errors, not required project references. * Merges networkserver unit tests. * Skips build when running unit tests. * Fixes path on the CI * Fixes path issues. * Deletes backup file. * Skips building again for integration tests. * Ensures that namespaces follow folder structure to avoid IDE0130. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Atif Aziz <code@raboof.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
The
Directory.Build.propswas moved in PR #493, but the reference in the solution file was not updated.How is this addressed
Updating the path to new location.