Add caching functionality#270
Conversation
…gotten from a link
updated for a new cargo package
… and serialization support
Cache handling
removed the 2 from wiki-tui2 and wiki_api2 for compatibiltiy with the…
…k to the original repo
made the version number the same as in the old repo before merging
There was a problem hiding this comment.
First of all, thank you for your time and this huge update to wiki-tui. I have a few things here and there to note but overall it looks very good.
From what I'm seeing, you published a new version of wiki-tui under wiki-tui2. After the PR has been merged, I can create a new release for version 0.9.2. Before that we'll have to update the version numbers of wiki-api and wiki-api-macros to only increase in one patch version. For the new version, do you have a changelog for the version, or should I write one?
| description = "Proc-macros for use within wiki-api" | ||
| documentation = "https://docs.rs/wiki-api-macros" | ||
| readme = "README.md" | ||
| homepage = "https://builditluc.github.io/wiki-tui" |
There was a problem hiding this comment.
Could you please change the homepage to https://wiki-tui.net
wiki-api/Cargo.toml
Outdated
| description = "Backend for wiki-tui" | ||
| documentation = "https://docs.rs/wiki-api" | ||
| homepage = "https://wiki-tui.net" | ||
| homepage = "https://github.com/builditluc/wiki-tui" |
There was a problem hiding this comment.
Same here as with wiki-api-macros
| ``` | ||
|
|
||
| If you want, you can also use the latest development version from GitHub (can be unstable) | ||
| If you want, you can also use the latest development version from the original GitHub repository (can be unstable) |
There was a problem hiding this comment.
Ig this could now be changed back
|
One more thing, currently the CI doesn't run because of the missing rust-toolchain. Could you either re-add it, or specify the toolchain specifically in the workflow (since the worflow file is specific to this pr)? |
Update Rust toolchain version and project links
removing the log files from git
|
Hello, I just email you a short changelog to wiki-tui@builditluc.eu with the most important changes if you want to take a look at it. let me know if there is anything else that you think could be improved! |
Builditluc
left a comment
Builditluc
left a comment
There was a problem hiding this comment.
Looks good, it seems that language switching doesn't work anymore (changing the language of an article)
|
@all-contributors please add @coderFeedForwardAlg for maintenance and code |
|
I've put up a pull request to add @coderFeedForwardAlg! 🎉 |
3 participants
This PR introduces a caching system by storing pages locally and avoiding repeated API calls for the same content.
Key Changes: