Repository navigation
fix: retry held UI dependencies with accessible controls - #448
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
…ld-dependency-retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 16 product Select triggers were audited. Roaming-network and hardware-profile controls now use their visible labels; exact-name tests cover both. The roaming browser test covers desktop/mobile widths. Managed primitives and visual baselines are unchanged.
The HUD's full-row native label still activates its details button. Before:
Idle Idle Stream health Bitrate: No data …, followed by six Network readings and temperature. After: exactlyIdlein that same common idle/six-link state; distinct health remains in other lifecycle names. Six link readings and the reason remain separately accessible; keyboard and telemetry-area activation are checked.Last ordered federation measurement for bits-ui 2.20.6: toast-host 681,359 / 688,543 B, audio 7,729 / 7,881 B gzip. No budget was raised.
After merging PR #450, head
bf41d6a5has 18 successful checks in run42691483609. Its CI bundle-report passes every SPA budget but explicitly reports federation output absent/skipped; it does not provide fresh toast-host/audio sizes. The merge changes only the canonical test fixture/playbook, so production inputs are unchanged. No build, test or workflow was manually rerun.Assertion changes (all original expect expressions are retained):
expect(opus.getAttribute("aria-disabled")).toBe("true")only when optional nodes existedexpect(opus.getAttribute("title")).toBeTruthy()only when optional nodes existedexpect(aac.getAttribute("aria-disabled")).not.toBe("true")only when optional nodes existedexpect(audioCodecAllowedForTransport("opus", "srtla")).toBe(false)in the fallback; removed in the earlier patchexpect(audioCodecAllowedForTransport("aac", "srtla")).toBe(true)in the fallback; removed in the earlier patchexpect(screen.queryByTestId("sim-unlock-dismiss")).toBeNull()immediatelywaitFor; original explanation retained${visible}.*Degraded.*No frames advancing${visible} Degraded, sameExpand detailsdescription, and separate exactNo frames advancingreason assertionIdlename and exactly six accessible Network link readingsalsa:hdmi,Available NetworksandSelect Hardware Profilecombobox names