Skip to content

fix: retry held UI dependencies with accessible controls - #448

Merged
andrescera merged 13 commits into
mainfrom
chore/held-dependency-retry
Nov 9, 2026
Merged

andrescera merged 13 commits into
mainfrom
chore/held-dependency-retry

Conversation

@andrescera

@andrescera andrescera commented Nov 9, 2026 •

Copy link
Copy Markdown
Member
  • What: Upgrade bits-ui to 2.20.6 and axe to 4.14.0; name every product Select and keep the HUD name concise.
  • Why: Handle upstream Select activation, combobox naming and exit frames.
  • How to verify: Lint/typecheck, full unit suites, 38 unchanged ABI tests, ordered build/federation/report, and component/browser accessibility tests.
  • Risks: Svelte remains 5.57.0 while issue #18919 is open; persistent-runes 2.2.0 remains blocked by its emitted runtime ABI. TypeScript stays 6.0.3.

All 16 product Select triggers were audited. Roaming-network and hardware-profile controls now use their visible labels; exact-name tests cover both. The roaming browser test covers desktop/mobile widths. Managed primitives and visual baselines are unchanged.

The HUD's full-row native label still activates its details button. Before: Idle Idle Stream health Bitrate: No data …, followed by six Network readings and temperature. After: exactly Idle in that same common idle/six-link state; distinct health remains in other lifecycle names. Six link readings and the reason remain separately accessible; keyboard and telemetry-area activation are checked.

Last ordered federation measurement for bits-ui 2.20.6: toast-host 681,359 / 688,543 B, audio 7,729 / 7,881 B gzip. No budget was raised.

After merging PR #450, head bf41d6a5 has 18 successful checks in run 42691483609. Its CI bundle-report passes every SPA budget but explicitly reports federation output absent/skipped; it does not provide fresh toast-host/audio sizes. The merge changes only the canonical test fixture/playbook, so production inputs are unchanged. No build, test or workflow was manually rerun.

Assertion changes (all original expect expressions are retained):

Contract Before After
Opus disabled expect(opus.getAttribute("aria-disabled")).toBe("true") only when optional nodes existed Same exact expression after required role discovery
Opus reason expect(opus.getAttribute("title")).toBeTruthy() only when optional nodes existed Same exact expression unconditionally
AAC enabled expect(aac.getAttribute("aria-disabled")).not.toBe("true") only when optional nodes existed Same exact expression unconditionally
Opus helper expect(audioCodecAllowedForTransport("opus", "srtla")).toBe(false) in the fallback; removed in the earlier patch Restored exactly and unconditional, alongside strict DOM checks
AAC helper expect(audioCodecAllowedForTransport("aac", "srtla")).toBe(true) in the fallback; removed in the earlier patch Restored exactly and unconditional; direct RPC coverage also remains
SIM removal expect(screen.queryByTestId("sim-unlock-dismiss")).toBeNull() immediately Same exact expression inside bounded waitFor; original explanation retained
HUD name Earlier patch accepted ${visible}.*Degraded.*No frames advancing Exact ${visible} Degraded, same Expand details description, and separate exact No frames advancing reason assertion
Idle with six links No concise-name assertion Exact Idle name and exactly six accessible Network link readings
Selector names No computed-name checks for the affected controls Exact alsa:hdmi, Available Networks and Select Hardware Profile combobox names

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 92762df1-30c0-4969-908d-b2292588419e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@andrescera
andrescera merged commit ea79444 into main Nov 9, 2026
18 checks passed
@andrescera
andrescera deleted the chore/held-dependency-retry branch November 10, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant