Repository navigation
fix(Select): give Select.Trigger the combobox role and aria-controls (#2134) - #2216
Merged
Merged
Conversation
- Set role="combobox" on Select.Trigger - Point aria-controls at the mounted listbox id, omitted while closed - Add single and multiple browser tests and a changeset
🦋 Changeset detectedLatest commit: 459ddd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Merged
4 tasks done
NonoHM
added a commit
to NonoHM/budgetpilot
that referenced
this pull request
Oct 29, 2026
* fix(deps): bits-ui 2.20.0, jose 6.2.13, re2js 2.9.0, zod 4.6.7 Runtime minors at the newest release past the repository's 7-day cooldown (.github/dependabot.yml), not the newest published: bits-ui 2.20.1 and 2.20.2, jose 6.2.14 and re2js 2.9.1 are under 7 days old and wait for Dependabot. zod 4.6.7 is the newest. No advisory is closed: every one of these was already past the patched line of every 2026 advisory against it. read-excel-file is left at 9.2.0 on purpose: 9.3.x replaces its XML parser (@xmldom/xmldom out, saxen and worker-f in) on the path that parses uploaded statements, which is its own tier 3 change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: query the Select trigger by its combobox role bits-ui 2.20.0 gives Select.Trigger role="combobox" (huntabyte/bits-ui#2216), the WAI-ARIA select-only combobox pattern; under 2.19.5 it was a plain button. Five component specs and two e2e steps looked the trigger up as a button and timed out. Measured: the three spec files fail 5 of 32 on 2.19.5 and pass 32 of 32 on 2.20.0, so each query separates the two versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
andrescera
added a commit
to CERALIVE/CeraUI
that referenced
this pull request
Nov 9, 2026
- What: Upgrade bits-ui to 2.20.6 and axe to 4.14.0; name every product Select and keep the HUD name concise. - Why: Handle upstream [Select activation](huntabyte/bits-ui#2227), [combobox naming](huntabyte/bits-ui#2216) and [exit frames](huntabyte/bits-ui#2199). - How to verify: Lint/typecheck, full unit suites, 38 unchanged ABI tests, ordered build/federation/report, and component/browser accessibility tests. - Risks: Svelte remains 5.57.0 while issue #18919 is open; persistent-runes 2.2.0 remains blocked by its emitted runtime ABI. TypeScript stays 6.0.3. All 16 product Select triggers were audited. Roaming-network and hardware-profile controls now use their visible labels; exact-name tests cover both. The roaming browser test covers desktop/mobile widths. Managed primitives and visual baselines are unchanged. The HUD's full-row native label still activates its details button. Before: `Idle Idle Stream health Bitrate: No data …`, followed by six Network readings and temperature. After: exactly `Idle` in that same common idle/six-link state; distinct health remains in other lifecycle names. Six link readings and the reason remain separately accessible; keyboard and telemetry-area activation are checked. With main's enforced ceilings, bits-ui 2.20.6 passes: toast-host **681,359 / 688,543 B**, audio **7,729 / 7,881 B** gzip. No budget was raised. Assertion changes (all original expect expressions are retained): | Contract | Before | After | | --- | --- | --- | | Opus disabled | `expect(opus.getAttribute("aria-disabled")).toBe("true")` only when optional nodes existed | Same exact expression after required role discovery | | Opus reason | `expect(opus.getAttribute("title")).toBeTruthy()` only when optional nodes existed | Same exact expression unconditionally | | AAC enabled | `expect(aac.getAttribute("aria-disabled")).not.toBe("true")` only when optional nodes existed | Same exact expression unconditionally | | Opus helper | `expect(audioCodecAllowedForTransport("opus", "srtla")).toBe(false)` in the fallback; removed in the earlier patch | Restored exactly and unconditional, alongside strict DOM checks | | AAC helper | `expect(audioCodecAllowedForTransport("aac", "srtla")).toBe(true)` in the fallback; removed in the earlier patch | Restored exactly and unconditional; direct RPC coverage also remains | | SIM removal | `expect(screen.queryByTestId("sim-unlock-dismiss")).toBeNull()` immediately | Same exact expression inside bounded `waitFor`; original explanation retained | | HUD name | Earlier patch accepted `${visible}.*Degraded.*No frames advancing` | Exact `${visible} Degraded`, same `Expand details` description, and separate exact `No frames advancing` reason assertion | | Idle with six links | No concise-name assertion | Exact `Idle` name and exactly six accessible Network link readings | | Selector names | No computed-name checks for the affected controls | Exact `alsa:hdmi`, `Available Networks` and `Select Hardware Profile` combobox names |
miyabi-satoh
added a commit
to miyabi-satoh/weblav
that referenced
this pull request
Nov 10, 2026
* Bump the cargo-minor-patch group across 1 directory with 8 updates Bumps the cargo-minor-patch group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [icu_normalizer](https://github.com/unicode-org/icu4x) | `2.3.0` | `2.4.0` | | [open](https://github.com/Byron/open-rs) | `5.4.4` | `5.4.5` | | [tao](https://github.com/tauri-apps/tao) | `0.37.1` | `0.37.2` | | [tokio](https://github.com/tokio-rs/tokio) | `1.53.3` | `1.54.1` | | [trash](https://github.com/ArturKovacs/trash) | `5.2.9` | `5.3.0` | | [ureq](https://github.com/algesten/ureq) | `3.4.2` | `3.5.1` | | [zip](https://github.com/zip-rs/zip2) | `9.0.5` | `9.3.0` | | [libc](https://github.com/rust-lang/libc) | `0.2.189` | `0.2.191` | Updates `icu_normalizer` from 2.3.0 to 2.4.0 - [Release notes](https://github.com/unicode-org/icu4x/releases) - [Changelog](https://github.com/unicode-org/icu4x/blob/main/CHANGELOG.md) - [Commits](https://github.com/unicode-org/icu4x/compare/icu@2.3.0...icu@2.4.0) Updates `open` from 5.4.4 to 5.4.5 - [Release notes](https://github.com/Byron/open-rs/releases) - [Changelog](https://github.com/Byron/open-rs/blob/main/changelog.md) - [Commits](Byron/open-rs@v5.4.4...v5.4.5) Updates `tao` from 0.37.1 to 0.37.2 - [Release notes](https://github.com/tauri-apps/tao/releases) - [Changelog](https://github.com/tauri-apps/tao/blob/dev/CHANGELOG.md) - [Commits](tauri-apps/tao@tao-v0.37.1...tao-v0.37.2) Updates `tokio` from 1.53.3 to 1.54.1 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.53.3...tokio-1.54.1) Updates `trash` from 5.2.9 to 5.3.0 - [Release notes](https://github.com/ArturKovacs/trash/releases) - [Changelog](https://github.com/Byron/trash-rs/blob/master/CHANGELOG.md) - [Commits](Byron/trash-rs@v5.2.9...v5.3.0) Updates `ureq` from 3.4.2 to 3.5.1 - [Changelog](https://github.com/algesten/ureq/blob/main/CHANGELOG.md) - [Commits](algesten/ureq@3.4.2...3.5.1) Updates `zip` from 9.0.5 to 9.3.0 - [Release notes](https://github.com/zip-rs/zip2/releases) - [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md) - [Commits](zip-rs/zip2@v9.0.5...v9.3.0) Updates `libc` from 0.2.189 to 0.2.191 - [Release notes](https://github.com/rust-lang/libc/releases) - [Changelog](https://github.com/rust-lang/libc/blob/0.2.191/CHANGELOG.md) - [Commits](rust-lang/libc@0.2.189...0.2.191) --- updated-dependencies: - dependency-name: icu_normalizer dependency-version: 2.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: open dependency-version: 5.4.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: tao dependency-version: 0.37.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: tokio dependency-version: 1.54.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: trash dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: ureq dependency-version: 3.5.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: zip dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: libc dependency-version: 0.2.191 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the npm-minor-patch group across 1 directory with 25 updates Bumps the npm-minor-patch group with 25 updates in the /frontend directory: | Package | From | To | | --- | --- | --- | | [@silurus/ooxml](https://github.com/yukiyokotani/office-open-xml-viewer) | `0.88.0` | `0.89.7` | | [dompurify](https://github.com/cure53/DOMPurify) | `3.4.16` | `3.4.17` | | [marked](https://github.com/markedjs/marked) | `18.1.0` | `18.1.3` | | [pdfjs-dist](https://github.com/mozilla/pdf.js) | `6.4.299` | `6.5.438` | | [virtua](https://github.com/inokawa/virtua) | `0.53.6` | `0.54.2` | | [@lucide/svelte](https://github.com/lucide-icons/lucide/tree/HEAD/packages/svelte) | `1.54.0` | `1.69.0` | | [@playwright/test](https://github.com/microsoft/playwright) | `1.64.0` | `1.64.1` | | [@tailwindcss/vite](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/@tailwindcss-vite) | `4.3.3` | `4.3.4` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.6.5` | `26.6.6` | | [@vitest/browser-playwright](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser-playwright) | `5.0.3` | `5.1.0` | | [bits-ui](https://github.com/huntabyte/bits-ui) | `2.19.5` | `2.20.6` | | [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) | `3.50.0` | `3.51.0` | | [eslint](https://github.com/eslint/eslint) | `10.12.0` | `10.14.0` | | [eslint-plugin-svelte](https://github.com/sveltejs/eslint-plugin-svelte/tree/HEAD/packages/eslint-plugin-svelte) | `3.23.1` | `3.24.0` | | [globals](https://github.com/sindresorhus/globals) | `17.13.0` | `17.14.0` | | [playwright](https://github.com/microsoft/playwright) | `1.64.0` | `1.64.1` | | [prettier](https://github.com/prettier/prettier) | `3.9.9` | `3.9.10` | | [shadcn-svelte](https://github.com/huntabyte/shadcn-svelte/tree/HEAD/packages/cli) | `1.7.0` | `1.8.0` | | [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) | `5.57.2` | `5.57.3` | | [svelte-check](https://github.com/sveltejs/language-tools) | `4.7.6` | `4.7.8` | | [svelte-sonner](https://github.com/wobsoriano/svelte-sonner) | `1.2.1` | `1.2.3` | | [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) | `4.3.3` | `4.3.4` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.71.1` | `8.72.1` | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `8.3.4` | `8.3.6` | | [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `5.0.3` | `5.1.0` | Updates `@silurus/ooxml` from 0.88.0 to 0.89.7 - [Release notes](https://github.com/yukiyokotani/office-open-xml-viewer/releases) - [Changelog](https://github.com/yukiyokotani/office-open-xml-viewer/blob/main/CHANGELOG.md) - [Commits](yukiyokotani/office-open-xml-viewer@v0.88.0...v0.89.7) Updates `dompurify` from 3.4.16 to 3.4.17 - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.16...3.4.17) Updates `marked` from 18.1.0 to 18.1.3 - [Release notes](https://github.com/markedjs/marked/releases) - [Commits](markedjs/marked@v18.1.0...v18.1.3) Updates `pdfjs-dist` from 6.4.299 to 6.5.438 - [Release notes](https://github.com/mozilla/pdf.js/releases) - [Commits](mozilla/pdf.js@v6.4.299...v6.5.438) Updates `virtua` from 0.53.6 to 0.54.2 - [Release notes](https://github.com/inokawa/virtua/releases) - [Commits](inokawa/virtua@0.53.6...0.54.2) Updates `@lucide/svelte` from 1.54.0 to 1.69.0 - [Release notes](https://github.com/lucide-icons/lucide/releases) - [Commits](https://github.com/lucide-icons/lucide/commits/1.69.0/packages/svelte) Updates `@playwright/test` from 1.64.0 to 1.64.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.64.0...v1.64.1) Updates `@tailwindcss/vite` from 4.3.3 to 4.3.4 - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.3.4/packages/@tailwindcss-vite) Updates `@types/node` from 26.6.5 to 26.6.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `@vitest/browser-playwright` from 5.0.3 to 5.1.0 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.1.0/packages/browser-playwright) Updates `bits-ui` from 2.19.5 to 2.20.6 - [Release notes](https://github.com/huntabyte/bits-ui/releases) - [Commits](https://github.com/huntabyte/bits-ui/compare/bits-ui@2.19.5...bits-ui@2.20.6) Updates `core-js` from 3.50.0 to 3.51.0 - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.51.0/packages/core-js) Updates `eslint` from 10.12.0 to 10.14.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.12.0...v10.14.0) Updates `eslint-plugin-svelte` from 3.23.1 to 3.24.0 - [Release notes](https://github.com/sveltejs/eslint-plugin-svelte/releases) - [Changelog](https://github.com/sveltejs/eslint-plugin-svelte/blob/main/packages/eslint-plugin-svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/eslint-plugin-svelte/commits/eslint-plugin-svelte@3.24.0/packages/eslint-plugin-svelte) Updates `globals` from 17.13.0 to 17.14.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v17.13.0...v17.14.0) Updates `playwright` from 1.64.0 to 1.64.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.64.0...v1.64.1) Updates `prettier` from 3.9.9 to 3.9.10 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.9.9...3.9.10) Updates `shadcn-svelte` from 1.7.0 to 1.8.0 - [Release notes](https://github.com/huntabyte/shadcn-svelte/releases) - [Changelog](https://github.com/huntabyte/shadcn-svelte/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/huntabyte/shadcn-svelte/commits/shadcn-svelte@1.8.0/packages/cli) Updates `svelte` from 5.57.2 to 5.57.3 - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/main/packages/svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@5.57.3/packages/svelte) Updates `svelte-check` from 4.7.6 to 4.7.8 - [Release notes](https://github.com/sveltejs/language-tools/releases) - [Commits](https://github.com/sveltejs/language-tools/compare/svelte-check@4.7.6...svelte-check@4.7.8) Updates `svelte-sonner` from 1.2.1 to 1.2.3 - [Release notes](https://github.com/wobsoriano/svelte-sonner/releases) - [Changelog](https://github.com/wobsoriano/svelte-sonner/blob/main/CHANGELOG.md) - [Commits](wobsoriano/svelte-sonner@v1.2.1...v1.2.3) Updates `tailwindcss` from 4.3.3 to 4.3.4 - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.3.4/packages/tailwindcss) Updates `typescript-eslint` from 8.71.1 to 8.72.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.72.1/packages/typescript-eslint) Updates `vite` from 8.3.4 to 8.3.6 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.6/packages/vite) Updates `vitest` from 5.0.3 to 5.1.0 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.1.0/packages/vitest) --- updated-dependencies: - dependency-name: "@silurus/ooxml" dependency-version: 0.89.7 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: dompurify dependency-version: 3.4.17 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: marked dependency-version: 18.1.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: pdfjs-dist dependency-version: 6.5.438 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: virtua dependency-version: 0.54.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: "@lucide/svelte" dependency-version: 1.69.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: "@playwright/test" dependency-version: 1.64.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: "@tailwindcss/vite" dependency-version: 4.3.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: "@types/node" dependency-version: 26.6.6 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: "@vitest/browser-playwright" dependency-version: 5.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: bits-ui dependency-version: 2.20.6 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: core-js dependency-version: 3.51.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: eslint dependency-version: 10.14.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: eslint-plugin-svelte dependency-version: 3.24.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: globals dependency-version: 17.14.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: playwright dependency-version: 1.64.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: prettier dependency-version: 3.9.10 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: shadcn-svelte dependency-version: 1.8.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: svelte dependency-version: 5.57.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: svelte-check dependency-version: 4.7.8 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: svelte-sonner dependency-version: 1.2.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: tailwindcss dependency-version: 4.3.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: typescript-eslint dependency-version: 8.72.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch - dependency-name: vite dependency-version: 8.3.6 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-patch - dependency-name: vitest dependency-version: 5.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com> * bits-ui 2.20 で選ぶ欄の役割が combobox になったのに、テストと撮影を合わせる - bits-ui 2.20.0 で、Select.Trigger の役割が button から combobox に変わった (huntabyte/bits-ui#2216)。e2e と撮影のスクリプトが、選ぶ欄を button の役割で探していたので、combobox で探す。 - 依存の更新に合わせて、Rust の依存のライセンスの一覧を作り直す。 * open 5.4.5 で that_detached が待つようになったので、トレイからは別スレッドで開く --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="combobox"toSelect.Triggerso assistive tech announces it as a combobox rather than a plain button.aria-controlson the trigger pointing at the mounted listbox's id. It is omitted while the content isn't mounted, so it never references a missing element.bits-ui.Testing
type="single"andtype="multiple"Select. They check that the trigger has thecomboboxrole, has noaria-controlswhile closed, getsaria-controlsmatching the listbox id when opened, and drops it again after Escape.