Conversation
viva-jinyi
requested review from
a team,
KarryCharon,
Yorha4D,
christian-byrne,
ltdrdata and
shinshin86
as code owners
dosubot
bot
added
the
size:XL
📝 WalkthroughWalkthroughRemoves dialogService manager APIs and responsive-collapse composable; adds useManagerDialog and rewires useManagerState to await it; rewrites ManagerDialog into BaseModalLayout with left/right panels and multi-select/grid logic; deletes several manager UI components and tests; updates button prop, types, locales, and global dialog sizing. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant useManagerState
participant useManagerDialog
participant DialogStore
participant GlobalDialog
participant ManagerDialog
Caller->>useManagerState: openManager(options?)
useManagerState->>useManagerDialog: show(initialTab?)
useManagerDialog->>DialogStore: dialogStore.show('global-manager', ManagerDialog, { props })
DialogStore->>GlobalDialog: register dialog entry (key: 'global-manager')
GlobalDialog->>ManagerDialog: mount component with props
ManagerDialog->>useManagerDialog: call onClose()
useManagerDialog->>DialogStore: dialogStore.close('global-manager')
DialogStore-->>GlobalDialog: remove dialog entry
Possibly related PRs
Suggested reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests: ✅ PassedResults: 507 passed, 0 failed, 0 flaky, 8 skipped (Total: 515) 📊 Browser Reports
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/16/2026, 06:51:47 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.36 MB (baseline 3.35 MB) • 🔴 +14.3 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1.14 MB (baseline 1.15 MB) • 🟢 -16.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.66 kB (baseline 6.66 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 203 kB (baseline 209 kB) • 🟢 -5.76 kBReusable component library chunks
Status: 9 added / 9 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.34 MB (baseline 9.34 MB) • 🟢 -232 BExternal libraries and shared vendor chunks
Status: 7 added / 7 removed Other — 5.38 MB (baseline 5.38 MB) • 🔴 +1 BBundles that do not match a named category
Status: 21 added / 21 removed |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/workbench/extensions/manager/components/manager/ManagerDialog.vue (2)
499-510: Consider usingcomputedinstead of watch for derived right panel state.The watch that sets
isRightPanelOpenbased onselectedNodePacks.value.length > 0is essentially deriving state. Per coding guidelines, prefercomputedoverrefwithwatchwhen the value is directly derivable.♻️ Suggested refactor
If
BaseModalLayoutsupports a computed value forv-model:right-panel-open, consider:-const isRightPanelOpen = ref(false) - -watch( - () => selectedNodePacks.value.length, - (length) => { - isRightPanelOpen.value = length > 0 - } -) +const isRightPanelOpen = computed({ + get: () => selectedNodePacks.value.length > 0, + set: (value) => { + if (!value) { + selectedNodePacks.value = [] + } + } +})This makes the relationship between selection and panel visibility explicit and eliminates the intermediate ref.
589-599: DOM query inonMountedand watch could be simplified.The pattern of assigning
gridContainerinonMountedand then re-querying in the watch with nullish coalescing is redundant. Consider using a template ref instead ofgetElementById.♻️ Suggested improvement using template ref
+import { useTemplateRef } from 'vue' + -let gridContainer: HTMLElement | null = null -onMounted(() => { - gridContainer = document.getElementById('results-grid') -}) +const gridContainerRef = useTemplateRef<HTMLElement>('results-grid') + watch([searchQuery, selectedNavId], () => { - gridContainer ??= document.getElementById('results-grid') + const gridContainer = gridContainerRef.value if (gridContainer) { pageNumber.value = 0 gridContainer.scrollTop = 0 } })Then in template, add
ref="results-grid"to the VirtualGrid or its container.
🤖 Fix all issues with AI agents
In `@src/workbench/extensions/manager/components/manager/ManagerDialog.vue`:
- Around line 533-550: The selectNodePack function mutates
selectedNodePacks.value in place using push and splice; change it to use
immutable updates so reactivity is clearer and safer: when adding, set
selectedNodePacks.value = [...selectedNodePacks.value, nodePack]; when removing,
set selectedNodePacks.value = selectedNodePacks.value.filter(pack => pack.id !==
nodePack.id); for the single-select case assign selectedNodePacks.value =
[nodePack]; keep the same shift/ctrl/metaKey branch and the same identity checks
(pack.id) to locate items.
- Around line 25-45: Replace the plain PrimeVue AutoComplete with the project's
AutoCompletePlus: change the import and component registration from AutoComplete
to AutoCompletePlus (use src/components/primevueOverride/AutoCompletePlus.vue),
then replace the <AutoComplete ... /> tag in ManagerDialog.vue with
<AutoCompletePlus ... /> leaving all props/events (v-model.lazy="searchQuery",
:suggestions="suggestions", `@option-select`="onOptionSelect",
`@complete`="stubTrue", etc.) unchanged so the IME composition support from
AutoCompletePlus is used.
In `@src/workbench/extensions/manager/composables/nodePack/useMissingNodes.ts`:
- Line 17: The inline comment "Uses the same filtering approach as
ManagerDialog.vue" in
src/workbench/extensions/manager/composables/nodePack/useMissingNodes.ts is
redundant after refactor—remove this file-reference comment or replace it with a
generic, self-contained note (e.g., "Uses same filtering logic as manager UI")
so the code remains self-documenting and resilient to future renames; update the
comment near the useMissingNodes export/function declaration accordingly.
In `@src/workbench/extensions/manager/composables/useManagerDialog.ts`:
- Around line 16-31: The show function in useManagerDialog.ts is marked async
but never awaits, which misleads callers like useManagerState.ts that do await
managerDialog.show(...); either remove the async keyword from the show function
and leave its current immediate-return behavior (adjust any callers that assumed
it awaited), or change show to return a Promise that resolves when the dialog
closes by wiring the Promise resolve into the onClose handler used in
dialogService.showLayoutDialog (referencing show, hide,
dialogService.showLayoutDialog, ManagerDialog and the onClose prop) so await
managerDialog.show(...) truly waits for the dialog to close.
In `@src/workbench/extensions/manager/composables/useManagerState.ts`:
- Around line 150-152: Hoist the useManagerDialog() call out of openManager and
instantiate it alongside the other composables in useManagerState (next to
dialogService and commandStore) so you reuse the same managerDialog instance
instead of recreating it on every openManager invocation; update openManager to
reference the outer-scoped managerDialog and remove any internal calls to
useManagerDialog(), ensuring existing references to useDialogService(),
useDialogStore(), and managerDialog remain valid.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (17)
src/components/dialog/GlobalDialog.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/composables/element/useResponsiveCollapse.tssrc/locales/en/main.jsonsrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/workbench/extensions/manager/components/manager/ManagerHeader.test.tssrc/workbench/extensions/manager/components/manager/ManagerHeader.vuesrc/workbench/extensions/manager/components/manager/ManagerNavSidebar.vuesrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/registrySearchBar/RegistrySearchBar.vuesrc/workbench/extensions/manager/components/manager/registrySearchBar/SearchFilterDropdown.vuesrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/types/comfyManagerTypes.ts
💤 Files with no reviewable changes (8)
- src/workbench/extensions/manager/types/comfyManagerTypes.ts
- src/workbench/extensions/manager/components/manager/registrySearchBar/SearchFilterDropdown.vue
- src/workbench/extensions/manager/components/manager/ManagerNavSidebar.vue
- src/composables/element/useResponsiveCollapse.ts
- src/workbench/extensions/manager/components/manager/ManagerHeader.test.ts
- src/workbench/extensions/manager/components/manager/ManagerHeader.vue
- src/workbench/extensions/manager/components/manager/registrySearchBar/RegistrySearchBar.vue
- src/components/dialog/GlobalDialog.vue
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using@ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements instead of inlinetypein mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, runpnpm formatbefore committing
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,vue}: Usereffor reactive state,computed()for derived values, andwatch/watchEffectfor side effects in Composition API
Avoid usingrefwithwatchif acomputedwould suffice - minimize refs and derived state
Useprovide/injectfor dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use<script setup lang="ts">for component logic in Vue SFCs
Avoid<style>blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries insrc/locales/en/main.json
Use Tailwind utility classes instead ofdark:variant - use semantic values fromstyle.csstheme (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging Tailwind class names instead of:class="[]"or hardcoding
Never use!importantor!Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g.,w-4/5instead ofw-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoidwithDefaultsor runtime props
PreferdefineModelover separately defining a prop and emit for v-model bindings
Define slots via template usage, not viadefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...
Files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g.,
MenuHamburger.vue)
Files:
src/components/widget/layout/BaseModalLayout.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/widget/layout/BaseModalLayout.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/widget/layout/BaseModalLayout.vue
🧠 Learnings (24)
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2026-01-12T17:39:27.738Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
Applied to files:
src/locales/en/main.json
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-22T21:36:46.909Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: tests-ui/tests/platform/cloud/subscription/components/SubscriptionPanel.test.ts:189-194
Timestamp: 2025-12-22T21:36:46.909Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: Do not stub primitive UI components or customized primitive components (e.g., Button). Instead, import and register the real components in test setup. This ensures tests accurately reflect production behavior and component API usage.
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Avoid new usage of PrimeVue components
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-06T02:11:00.385Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/rightSidePanel/RightSidePanel.vue:174-180
Timestamp: 2025-12-06T02:11:00.385Z
Learning: PrimeVue components have poor TypeScript typing, so type assertions (like `as RightSidePanelTab`) may be necessary when handling emitted events or prop values from PrimeVue components like TabList.
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Use `ref` for reactive state, `computed()` for derived values, and `watch`/`watchEffect` for side effects in Composition API
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Avoid using `ref` with `watch` if a `computed` would suffice - minimize refs and derived state
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
🧬 Code graph analysis (1)
src/workbench/extensions/manager/composables/useManagerState.ts (1)
src/workbench/extensions/manager/composables/useManagerDialog.ts (1)
useManagerDialog(8-37)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: collect
- GitHub Check: test
- GitHub Check: lint-and-format
🔇 Additional comments (16)
src/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.ts (1)
10-10: LGTM!The docstring updates correctly reflect the component renaming from
ManagerDialogContent.vuetoManagerDialog.vue, keeping documentation consistent with the broader refactor.Also applies to: 37-37
src/locales/en/main.json (1)
275-275: LGTM!The simplified title "Nodes Manager" is cleaner and aligns with the broader dialog consolidation in this PR.
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vue (2)
2-13: Verify removal ofvariant="textonly"is intentional.The
variant="textonly"prop was removed from the Button component. This changes the button's visual appearance from a text-only style to the default variant. Ensure this styling change is intentional for the consolidated manager dialog UI.
27-31: LGTM!The
sizeprop follows Vue 3.5 style with reactive props destructuring and a sensible default of'sm'. TheButtonVariants['size']type ensures type-safety.src/services/dialogService.ts (1)
383-413: LGTM!The widened
propstype withRecord<string, unknown>provides the flexibility needed for the consolidatedManagerDialogcomponent to receive additional props likeinitialTab. The requiredonClosecallback is still enforced while allowing pass-through of dialog-specific props.src/components/widget/layout/BaseModalLayout.vue (4)
110-120: LGTM!The
v-model:rightPanelOpenpattern is correctly implemented using Vue 3.5 style props destructuring with a default value and the corresponding emit definition. This enables external control of the right panel state as intended for the ManagerDialog integration.
136-144: Consider usingimmediate: trueon the watch if external updates on mount are expected.The current watch syncs prop changes to internal state, but if the parent provides
rightPanelOpenafter initial render (e.g., async data), the sync works correctly. However, the initialization on line 136 already handles the mount case. The implementation is correct for the v-model pattern.
169-172: LGTM!The toggle correctly updates internal state first, then emits the new value, maintaining proper v-model two-way binding semantics.
91-96: Verify the padding adjustment aligns with design requirements.The right aside now has
pt-16 pb-8padding. Ensure this vertical spacing (64px top, 32px bottom) provides proper alignment with the header and content areas in the consolidated manager dialog.src/workbench/extensions/manager/components/manager/ManagerDialog.vue (4)
72-79: Dismiss button implementation looks good.The Button component usage with variant and size props follows the project's common button component pattern correctly.
133-151: Grid click handler and selection logic are well-implemented.The click handling with
@click.stopand thehandleGridContainerClickpattern for deselection is a clean approach. The multi-select logic with Shift/Ctrl/Meta key detection is correct.
165-178: Imports are properly organized with separate type imports.Good adherence to the coding guideline requiring separate
import typestatements from regular imports.
209-214: Props and provide pattern correctly implemented.Using TypeScript 3.5 style for props definition and providing
OnCloseKeyfor child component consumption aligns with the new dialog architecture.src/workbench/extensions/manager/composables/useManagerDialog.ts (1)
6-14: DIALOG_KEY constant and hide function are well-structured.Using a constant for the dialog key and properly encapsulating the close logic follows good practices.
src/workbench/extensions/manager/composables/useManagerState.ts (2)
182-194: NEW_UI case handling is clear and follows the side-effect pattern correctly.The if/else structure for
isLegacyOnlyfollows the learned preference for using if/else over ternaries when performing side effects. The toast message followed by opening the dialog provides appropriate user feedback.
10-11: Import addition is properly separated.The new import for
useManagerDialogis correctly placed with other composable imports, and the type import forManagerTabremains on its own line as required by the linting rules.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
Outdated
Show resolved
Hide resolved
src/workbench/extensions/manager/composables/nodePack/useMissingNodes.ts
Outdated
Show resolved
Hide resolved
src/workbench/extensions/manager/composables/useManagerDialog.ts
Outdated
Show resolved
Hide resolved
src/workbench/extensions/manager/composables/useManagerState.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/workbench/extensions/manager/composables/useManagerDialog.ts`:
- Around line 24-27: The dialogComponentProps object uses Tailwind's `!`
important prefix in the class string (dialogComponentProps -> pt -> content ->
class: '!px-0 overflow-hidden h-full !py-0'); remove the `!` prefixes and
resolve the underlying conflict by either making the selector more specific
(adjust the dialog content/root CSS or remove the conflicting base padding) or
use the component passthrough API to supply a non-conflicting class (e.g., add a
dedicated utility class with higher specificity) so padding is controlled
without `!important`.
♻️ Duplicate comments (3)
src/workbench/extensions/manager/composables/useManagerDialog.ts (1)
16-30: Unnecessaryasynckeyword onshowfunction.The
showfunction is markedasyncbut doesn't useawait. This is misleading for callers that mightawait managerDialog.show(...)expecting it to resolve when the dialog closes.Either remove the
asynckeyword, or return a Promise that resolves whenonCloseis called if awaiting dialog closure is the intended behavior.src/workbench/extensions/manager/components/manager/ManagerDialog.vue (2)
25-45: UseAutoCompletePlusinstead of plain PrimeVueAutoComplete.Per coding guidelines, avoid new usage of PrimeVue components. The codebase provides
AutoCompletePlusatsrc/components/primevueOverride/AutoCompletePlus.vuewhich adds IME composition event support.
533-550: Consider immutable array operations for clarity.The
selectNodePackfunction usespushandsplicewhich mutate the array in place. While Vue's reactivity handles this, immutable patterns improve clarity.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
src/components/widget/layout/BaseModalLayout.vuesrc/locales/en/main.jsonsrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/useManagerDialog.ts
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using@ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements instead of inlinetypein mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, runpnpm formatbefore committing
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,vue}: Usereffor reactive state,computed()for derived values, andwatch/watchEffectfor side effects in Composition API
Avoid usingrefwithwatchif acomputedwould suffice - minimize refs and derived state
Useprovide/injectfor dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible
Files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use<script setup lang="ts">for component logic in Vue SFCs
Avoid<style>blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries insrc/locales/en/main.json
Use Tailwind utility classes instead ofdark:variant - use semantic values fromstyle.csstheme (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging Tailwind class names instead of:class="[]"or hardcoding
Never use!importantor!Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g.,w-4/5instead ofw-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoidwithDefaultsor runtime props
PreferdefineModelover separately defining a prop and emit for v-model bindings
Define slots via template usage, not viadefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...
Files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g.,
MenuHamburger.vue)
Files:
src/components/widget/layout/BaseModalLayout.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/widget/layout/BaseModalLayout.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/widget/layout/BaseModalLayout.vue
🧠 Learnings (32)
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-12T17:39:27.738Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
Applied to files:
src/locales/en/main.json
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Use `ref` for reactive state, `computed()` for derived values, and `watch`/`watchEffect` for side effects in Composition API
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Avoid using `ref` with `watch` if a `computed` would suffice - minimize refs and derived state
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Avoid new usage of PrimeVue components
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Calendar component with DatePicker
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Avoid mutable state - prefer immutability and assignment at point of declaration
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Watch out for Code Smells and refactor to avoid them
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-22T21:36:46.909Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: tests-ui/tests/platform/cloud/subscription/components/SubscriptionPanel.test.ts:189-194
Timestamp: 2025-12-22T21:36:46.909Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: Do not stub primitive UI components or customized primitive components (e.g., Button). Instead, import and register the real components in test setup. This ensures tests accurately reflect production behavior and component API usage.
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-06T02:11:00.385Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/rightSidePanel/RightSidePanel.vue:174-180
Timestamp: 2025-12-06T02:11:00.385Z
Learning: PrimeVue components have poor TypeScript typing, so type assertions (like `as RightSidePanelTab`) may be necessary when handling emitted events or prop values from PrimeVue components like TabList.
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
🔇 Additional comments (8)
src/locales/en/main.json (1)
276-276: LGTM!The simplified title "Nodes Manager" is cleaner and more concise.
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vue (1)
21-35: LGTM!The dynamic
sizeprop implementation follows Vue 3.5 style prop destructuring with proper TypeScript typing fromButtonVariants. The default value of'sm'maintains backward compatibility.src/components/widget/layout/BaseModalLayout.vue (2)
110-141: LGTM on the v-model:rightPanelOpen implementation.The two-way binding is correctly implemented:
- Prop
rightPanelOpenwith defaultfalse- Emit
update:rightPanelOpenon state changes- Watch syncs external prop changes to internal
isRightPanelOpenrefThe pattern correctly allows both controlled (parent-driven) and uncontrolled usage.
3-21: Improved button sizing for panel toggles.The change to
size="lg"for panel toggle buttons improves touch targets and visual consistency across the modal layout.src/workbench/extensions/manager/components/manager/ManagerDialog.vue (4)
209-214: LGTM on the provide/inject pattern for onClose.The
onClosecallback is correctly provided viaOnCloseKey, allowing child components likeBaseModalLayoutto trigger dialog closure without prop drilling.
503-510: LGTM on auto-open behavior for right panel.The watch correctly auto-opens the info panel when items are selected, aligning with the PR objective of "clicking a node card now auto-opens the info panel."
166-166: LGTM on es-toolkit usage.Using
mergefrom es-toolkit for deep merging pack data andstubTrueas a no-op follows the coding guideline to "use es-toolkit for utility functions."
614-616: LGTM on cleanup.The
onUnmountedhook properly cancels the pendinggetPackByIdrequest, preventing potential memory leaks or stale updates.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
viva-jinyi
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/workbench/extensions/manager/composables/useManagerState.test.ts (1)
36-42: Remove non-existent methods from dialogService mock.The mock includes
showManagerPopupandshowLegacyManagerPopupwhich don't exist in the actualdialogServiceimplementation. After the refactoring that introduceduseManagerDialog, onlyshowSettingsDialogis used byuseManagerState. Remove the stale methods from the mock:Mock before:
vi.mock('@/services/dialogService', () => ({ useDialogService: vi.fn(() => ({ showManagerPopup: vi.fn(), showLegacyManagerPopup: vi.fn(), showSettingsDialog: vi.fn() })) }))Mock after:
vi.mock('@/services/dialogService', () => ({ useDialogService: vi.fn(() => ({ showSettingsDialog: vi.fn() })) }))
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
browser_tests/tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/workbench/extensions/manager/composables/useManagerState.test.ts
🧰 Additional context used
📓 Path-based instructions (11)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using@ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements instead of inlinetypein mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, runpnpm formatbefore committing
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
+(tests-ui|src)/**/*.test.ts
📄 CodeRabbit inference engine (AGENTS.md)
+(tests-ui|src)/**/*.test.ts: Unit and component tests belong intests-ui/orsrc/**/*.test.tsusing Vitest
Write tests for all changes, especially bug fixes to catch future regressions
Do not write tests dependent on non-behavioral features like utility classes or styles
Do not write tests that just test the mocks - ensure tests fail when code behaves unexpectedly
Leverage Vitest's utilities for mocking where possible
Keep module mocks contained - do not use global mutable state within test files; usevi.hoisted()if necessary
Use Vue Test Utils for Component testing and follow best practices for making components easy to test
Aim for behavioral coverage of critical and new features in unit tests
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,vue}: Usereffor reactive state,computed()for derived values, andwatch/watchEffectfor side effects in Composition API
Avoid usingrefwithwatchif acomputedwould suffice - minimize refs and derived state
Useprovide/injectfor dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
+(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts)
📄 CodeRabbit inference engine (AGENTS.md)
+(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts): Do not write change detector tests - avoid tests that only assert default values
Be parsimonious in testing - do not write redundant tests
Don't Mock What You Don't Own
Files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
🧠 Learnings (17)
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Keep module mocks contained - do not use global mutable state within test files; use `vi.hoisted()` if necessary
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Leverage Vitest's utilities for mocking where possible
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts) : Don't Mock What You Don't Own
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-08T02:40:15.482Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7894
File: src/renderer/extensions/vueNodes/widgets/components/WidgetToggleSwitch.test.ts:11-14
Timestamp: 2026-01-08T02:40:15.482Z
Learning: In TypeScript test files (e.g., any test under src), avoid duplicating interface/type definitions. Import real type definitions from the component modules under test and reference them directly, so there is a single source of truth and to prevent type drift. This improves maintainability and consistency across tests.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-11-24T19:48:09.318Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Mocks should be cleanly written and easy to understand, with reusable mocks where possible
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Do not write tests that just test the mocks - ensure tests fail when code behaves unexpectedly
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-22T21:36:46.909Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: tests-ui/tests/platform/cloud/subscription/components/SubscriptionPanel.test.ts:189-194
Timestamp: 2025-12-22T21:36:46.909Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: Do not stub primitive UI components or customized primitive components (e.g., Button). Instead, import and register the real components in test setup. This ensures tests accurately reflect production behavior and component API usage.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Use Vue Test Utils for Component testing and follow best practices for making components easy to test
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-10T03:09:13.807Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7303
File: src/components/topbar/CurrentUserPopover.test.ts:199-205
Timestamp: 2025-12-10T03:09:13.807Z
Learning: In test files, prefer selecting or asserting on accessible properties (text content, aria-label, role, accessible name) over data-testid attributes. This ensures tests validate actual user-facing behavior and accessibility, reducing reliance on implementation details like test IDs.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-30T01:31:04.927Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7797
File: tests-ui/tests/lib/litegraph/src/widgets/ComboWidget.test.ts:648-648
Timestamp: 2025-12-30T01:31:04.927Z
Learning: In Vitest v4, when mocking functions that may be called as constructors (using new), the mock implementation must use function() or class syntax rather than an arrow function. Arrow mocks can cause '<anonymous> is not a constructor' errors. This is a breaking change from Vitest v3 where mocks could use an arrow function. Apply this guideline to test files that mock constructor-like calls (e.g., in tests under tests-ui, such as ComboWidget.test.ts) and ensure mock implementations are defined with function() { ... } or class { ... } to preserve constructor behavior.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-09T02:07:54.558Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7898
File: src/composables/usePaste.test.ts:248-248
Timestamp: 2026-01-09T02:07:54.558Z
Learning: In test files (e.g., any .test.ts or .test.tsx under src/...), when you create mock objects that partially implement an interface (such as LGraphNode), prefer casting with as Partial<InterfaceType> as InterfaceType rather than as any or as unknown as InterfaceType. This makes the incomplete implementation explicit while preserving type safety, improving readability and maintainability of tests.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
📚 Learning: 2026-01-12T17:39:27.738Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.
Applied to files:
src/workbench/extensions/manager/composables/useManagerState.test.ts
🔇 Additional comments (1)
src/workbench/extensions/manager/composables/useManagerState.test.ts (1)
56-61: LGTM!The mock correctly provides the
showandhidemethods expected byuseManagerDialog, following the same pattern as other mocks in this file. Since these tests focus on state computation rather than dialog behavior, the mock appropriately serves to resolve the import dependency.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
There was a problem hiding this comment.
Oh god, because the numbers are different widths?
😧
| variant="textonly" | ||
| class="border" | ||
| size="sm" | ||
| :size="size" |
There was a problem hiding this comment.
Optional:
| :size="size" | |
| :size |
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
Other than using defineModel and not needing the watch, looks good!
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/widget/layout/BaseModalLayout.vue (1)
3-21: Add accessible labels for icon-only buttons.
Both the right-panel toggle and close buttons are icon-only; please add localizedaria-labels so screen readers have an accessible name. Based on learnings, icon-only buttons must provide an aria-label.🔧 Suggested update
- <Button + <Button v-show="!isRightPanelOpen && hasRightPanel" size="lg" + :aria-label="t('rightSidePanel.togglePanel')" :class=" cn('absolute top-4 right-18 z-10', 'transition-opacity duration-200', { 'opacity-0 pointer-events-none': isRightPanelOpen || !hasRightPanel }) " `@click`="toggleRightPanel" > <i class="icon-[lucide--panel-right]" /> </Button> <Button size="lg" class="absolute top-4 right-6 z-10 transition-opacity duration-200 w-10" + :aria-label="t('g.close')" `@click`="closeDialog" > <i class="pi pi-times" /> </Button>-import { computed, inject, ref, useSlots, watch } from 'vue' +import { computed, inject, ref, useSlots, watch } from 'vue' +import { useI18n } from 'vue-i18n' ... +const { t } = useI18n()
🤖 Fix all issues with AI agents
In `@src/workbench/extensions/manager/components/manager/ManagerDialog.vue`:
- Around line 116-118: The GridSkeleton prop is currently bound as a boolean due
to using :skeleton-card-count without a value; change the binding to use the
computed numeric value by setting the prop to skeletonCardCount (i.e.
:skeleton-card-count="skeletonCardCount") wherever GridSkeleton is rendered
(e.g., the instance inside ManagerDialog.vue and the other occurrences around
the 527-531 region) so the skeleton renders the correct number of cards; ensure
the computed property name skeletonCardCount is referenced exactly.
- Around line 503-510: The watcher currently only observes
selectedNodePacks.value.length so it won't fire when the array contents change
but its length stays the same; update the watch to observe the array itself
(selectedNodePacks) and set isRightPanelOpen.value = packs.length > 0 in the
callback, or use watch(() => selectedNodePacks.value, (packs) => {...}, { deep:
true }) to detect item changes; adjust the watcher that references
selectedNodePacks/value and isRightPanelOpen to use the array watcher (and
deep:true if mutations keep the same array reference).
♻️ Duplicate comments (1)
src/workbench/extensions/manager/composables/useManagerDialog.ts (1)
24-27: Avoid Tailwind!prefix in dialog content classes.
Use non-!utilities or resolve padding via component styling instead. As per coding guidelines, avoid Tailwind!importantprefixes.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (9)
src/components/widget/layout/BaseModalLayout.vuesrc/locales/en/main.jsonsrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/ManagerDialog.vuesrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.tssrc/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.tssrc/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.ts
💤 Files with no reviewable changes (2)
- src/workbench/extensions/manager/composables/nodePack/useMissingNodes.ts
- src/workbench/extensions/manager/composables/nodePack/useUpdateAvailableNodes.ts
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using@ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements instead of inlinetypein mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, runpnpm formatbefore committing
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,vue}: Usereffor reactive state,computed()for derived values, andwatch/watchEffectfor side effects in Composition API
Avoid usingrefwithwatchif acomputedwould suffice - minimize refs and derived state
Useprovide/injectfor dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible
Files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use<script setup lang="ts">for component logic in Vue SFCs
Avoid<style>blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries insrc/locales/en/main.json
Use Tailwind utility classes instead ofdark:variant - use semantic values fromstyle.csstheme (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging Tailwind class names instead of:class="[]"or hardcoding
Never use!importantor!Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g.,w-4/5instead ofw-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoidwithDefaultsor runtime props
PreferdefineModelover separately defining a prop and emit for v-model bindings
Define slots via template usage, not viadefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...
Files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g.,
MenuHamburger.vue)
Files:
src/components/widget/layout/BaseModalLayout.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/widget/layout/BaseModalLayout.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/widget/layout/BaseModalLayout.vue
🧠 Learnings (45)
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
Applied to files:
src/locales/en/main.json
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/composables/**/*.ts : Name composables as `useXyz.ts` (e.g., `useForm.ts`)
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Never use `!important` or `!` Tailwind prefix - fix interfering classes instead
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-09T21:40:19.792Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:19.792Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, inline Tailwind CSS class strings, even when long, are acceptable and preferred over extracting them to computed properties when the classes are static. This is a common Tailwind pattern and doesn't need to be flagged as a readability issue.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-18T20:39:30.137Z
Learnt from: jtydhr88
Repo: Comfy-Org/ComfyUI_frontend PR: 7621
File: src/components/load3d/Load3DScene.vue:4-4
Timestamp: 2025-12-18T20:39:30.137Z
Learning: In src/components/load3d/Load3DScene.vue, the scoped `<style>` block with `!important` declarations for the canvas element is necessary because Three.js dynamically creates the canvas with inline styles, preventing direct application of Tailwind classes. This is a valid exception to the Tailwind-only styling guideline.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-18T02:07:44.374Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:44.374Z
Learning: Comfy-Org/ComfyUI_frontend uses Tailwind CSS v4 utilities, including the new “safe” overflow-alignment classes. Do not flag items-center-safe, justify-*-safe, or place-*-safe utilities as invalid in src/**/*.vue or stories.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2026-01-08T02:26:27.225Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:27.225Z
Learning: In Comfy-Org/ComfyUI_frontend, the `cn` utility function from `@/utils/tailwindUtil` uses `tailwind-merge`, which intelligently resolves conflicting Tailwind classes by keeping the last one. When a component uses `cn('base-classes bg-default', propClass)`, if `propClass` contains a conflicting background class, `tailwind-merge` will correctly override `bg-default` with the value from `propClass`. This additive pattern is correct and intentional, following the shadcn-ui convention.
</learning]
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Avoid `<style>` blocks in Vue components - use Tailwind 4 styling instead
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-01T23:42:30.894Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7084
File: src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue:23-26
Timestamp: 2025-12-01T23:42:30.894Z
Learning: In the ComfyUI frontend codebase, Tailwind CSS is configured with Preflight enabled (default), which automatically provides `content: ''` for pseudo-elements when using `after:` or `before:` variants - no need to explicitly add `after:content-['']`.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-16T17:30:29.719Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7559
File: .storybook/preview.ts:61-61
Timestamp: 2025-12-16T17:30:29.719Z
Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Use Tailwind utility classes instead of `dark:` variant - use semantic values from `style.css` theme (e.g., `bg-node-component-surface`)
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-22T21:36:16.031Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:16.031Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, avoid creating single-use variants for the Button component (and other UI components). Variants should be reusable across multiple use cases. It's acceptable to use a mix of variant props and manual Tailwind classes temporarily when a specific styling need exists in only one place, with consolidation deferred to a later phase when patterns emerge.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-12T17:39:27.738Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.
Applied to files:
src/workbench/extensions/manager/composables/useManagerDialog.tssrc/workbench/extensions/manager/composables/useManagerState.tssrc/services/dialogService.tssrc/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/widget/layout/BaseModalLayout.vuesrc/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Prefer `defineModel` over separately defining a prop and emit for v-model bindings
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Avoid using `ref` with `watch` if a `computed` would suffice - minimize refs and derived state
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Use `ref` for reactive state, `computed()` for derived values, and `watch`/`watchEffect` for side effects in Composition API
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/widget/layout/BaseModalLayout.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Avoid new usage of PrimeVue components
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Calendar component with DatePicker
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Avoid mutable state - prefer immutability and assignment at point of declaration
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Watch out for Code Smells and refactor to avoid them
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-22T21:36:46.909Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: tests-ui/tests/platform/cloud/subscription/components/SubscriptionPanel.test.ts:189-194
Timestamp: 2025-12-22T21:36:46.909Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: Do not stub primitive UI components or customized primitive components (e.g., Button). Instead, import and register the real components in test setup. This ensures tests accurately reflect production behavior and component API usage.
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
📚 Learning: 2025-12-06T02:11:00.385Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/rightSidePanel/RightSidePanel.vue:174-180
Timestamp: 2025-12-06T02:11:00.385Z
Learning: PrimeVue components have poor TypeScript typing, so type assertions (like `as RightSidePanelTab`) may be necessary when handling emitted events or prop values from PrimeVue components like TabList.
Applied to files:
src/workbench/extensions/manager/components/manager/ManagerDialog.vue
🧬 Code graph analysis (1)
src/workbench/extensions/manager/composables/useManagerState.ts (1)
src/workbench/extensions/manager/composables/useManagerDialog.ts (1)
useManagerDialog(8-36)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: playwright-tests-chromium-sharded (6, 8)
- GitHub Check: playwright-tests-chromium-sharded (4, 8)
- GitHub Check: playwright-tests-chromium-sharded (8, 8)
- GitHub Check: playwright-tests-chromium-sharded (7, 8)
- GitHub Check: playwright-tests-chromium-sharded (2, 8)
- GitHub Check: playwright-tests-chromium-sharded (5, 8)
- GitHub Check: playwright-tests (mobile-chrome)
- GitHub Check: playwright-tests-chromium-sharded (3, 8)
- GitHub Check: playwright-tests (chromium-2x)
- GitHub Check: playwright-tests-chromium-sharded (1, 8)
- GitHub Check: playwright-tests (chromium-0.5x)
🔇 Additional comments (10)
src/workbench/extensions/manager/components/manager/button/PackUpdateButton.vue (1)
7-7: Good: size prop is now configurable and typed.
Clear typing plus a default value makes the component more reusable.Also applies to: 27-35
src/locales/en/main.json (1)
275-277: LGTM for the title update.src/workbench/extensions/manager/composables/useManagerState.ts (1)
182-194: ClarifyisLegacyOnlybehavior vs. the JSDoc.
The JSDoc says it should show an error instead of opening the manager, but the NEW_UI branch now still callsmanagerDialog.show(...). Please confirm the intended behavior and either remove the show call or update the JSDoc to match.src/services/dialogService.ts (1)
394-399: LGTM: layout dialog prop widening is safe.
Allows extra props while keepingonCloserequired and typed.src/workbench/extensions/manager/components/manager/ManagerDialog.vue (6)
2-47: Layout + search header consolidation looks clean and cohesive.
49-113: Conflict banner + action/filter row placement is clear and user-friendly.
154-160: Right-panel rendering logic is straightforward and easy to follow.
165-311: State wiring and option derivations are well-structured.
533-551: Selection updates are now immutable and clearer.
595-613: Scroll reset + persistence hook-up is solid and centralized.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| <template #content> | ||
| <div v-if="isLoading" class="scrollbar-hide h-full w-full overflow-auto"> | ||
| <GridSkeleton :grid-style="GRID_STYLE" :skeleton-card-count /> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, find and verify GridSkeleton component
find src -name "GridSkeleton.vue" -type fRepository: Comfy-Org/ComfyUI_frontend
Length of output: 147
🏁 Script executed:
#!/bin/bash
# View GridSkeleton component to check prop definition
cat -n src/workbench/extensions/manager/components/manager/skeleton/GridSkeleton.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 675
🏁 Script executed:
#!/bin/bash
# View ManagerDialog.vue to check lines 116-118 and 527-531
sed -n '110,125p' src/workbench/extensions/manager/components/manager/ManagerDialog.vue
echo "---"
sed -n '520,535p' src/workbench/extensions/manager/components/manager/ManagerDialog.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 935
🏁 Script executed:
#!/bin/bash
# Check if skeletonCardCount is defined in ManagerDialog.vue
rg -n "skeletonCardCount" src/workbench/extensions/manager/components/manager/ManagerDialog.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 116
Bind GridSkeleton to the computed count (currently passes boolean).
:skeleton-card-count without a value binds true, ignoring the skeletonCardCount computed property which returns the correct numeric count. This causes the skeleton grid to render with an incorrect count.
✅ Proposed fix
- <GridSkeleton :grid-style="GRID_STYLE" :skeleton-card-count />
+ <GridSkeleton
+ :grid-style="GRID_STYLE"
+ :skeleton-card-count="skeletonCardCount"
+ />Also applies to: 527-531
🤖 Prompt for AI Agents
In `@src/workbench/extensions/manager/components/manager/ManagerDialog.vue` around
lines 116 - 118, The GridSkeleton prop is currently bound as a boolean due to
using :skeleton-card-count without a value; change the binding to use the
computed numeric value by setting the prop to skeletonCardCount (i.e.
:skeleton-card-count="skeletonCardCount") wherever GridSkeleton is rendered
(e.g., the instance inside ManagerDialog.vue and the other occurrences around
the 527-531 region) so the skeleton renders the correct number of cards; ensure
the computed property name skeletonCardCount is referenced exactly.
There was a problem hiding this comment.
Look up how Vue binding short-hand works.
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Vue 3.4 same-name shorthand syntax attribute binding
💡 Result:
Yes — starting in Vue 3.4 you can omit the expression when v-bind’s argument name matches the JavaScript variable name. For example:
- :id is shorthand for :id="id" (equivalently v-bind:id or v-bind:id="id"). [1][2]
Notes:
- This is part of the v-bind shorthand feature added in Vue 3.4. [1][2]
Sources:
[1] Vue built-in directives (v-bind) documentation.
[2] Announcing Vue 3.4 (blog post).
@DrJKL, you're absolutely right! I apologize for the incorrect analysis.
Vue 3.4+ supports same-name shorthand syntax where :skeleton-card-count is equivalent to :skeleton-card-count="skeletonCardCount". In Vue SFCs with a build step, the kebab-case attribute name automatically resolves to the corresponding camelCase variable name in scope.
The current code is correct as written:
<GridSkeleton :grid-style="GRID_STYLE" :skeleton-card-count />This automatically binds to the skeletonCardCount computed property through Vue's kebab-case-to-camelCase conversion combined with the same-name shorthand feature.
I see this is already documented in the project's learnings (IDs: ea4d9440, b9da2798, 7d6bc980), so this pattern is well-established in the codebase. Thank you for the correction!
🧠 Learnings used
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Use same-name shorthand for slot prop bindings (e.g., `:isExpanded` instead of `:is-expanded="isExpanded"`)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement computed properties with computed()
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Avoid using `ref` with `watch` if a `computed` would suffice - minimize refs and derived state
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7121
File: src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue:3-18
Timestamp: 2025-12-03T03:14:48.687Z
Learning: Vue 3.4+ supports same-name shorthand syntax for attribute bindings where `:id` is equivalent to `:id="id"` when the attribute name matches the variable name in scope. This is valid syntax and should not be flagged as an error.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Prefer `defineModel` over separately defining a prop and emit for v-model bindings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement lifecycle hooks with onMounted, onUpdated, etc.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Use `ref` for reactive state, `computed()` for derived values, and `watch`/`watchEffect` for side effects in Composition API
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/rightSidePanel/parameters/SectionWidgets.vue:41-49
Timestamp: 2025-12-05T08:52:50.787Z
Learning: In Vue 3.4+ SFCs with a build step, kebab-case prop shorthand (e.g., `:is-empty`) automatically resolves to the corresponding camelCase variable in scope (e.g., `isEmpty`). This is valid syntax combining same-name shorthand with automatic kebab-case-to-camelCase conversion and should not be flagged as an error.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
| const isRightPanelOpen = ref(false) | ||
|
|
||
| watch( | ||
| () => selectedNodePacks.value.length, | ||
| (length) => { | ||
| isRightPanelOpen.value = length > 0 | ||
| } | ||
| ) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, verify the file exists and check its size
wc -l src/workbench/extensions/manager/components/manager/ManagerDialog.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 143
🏁 Script executed:
# Read the specific lines mentioned in the review
sed -n '500,520p' src/workbench/extensions/manager/components/manager/ManagerDialog.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 730
🏁 Script executed:
# Search for selectedNodePacks definition and usage pattern
rg -A 5 -B 5 'selectedNodePacks' src/workbench/extensions/manager/components/manager/ManagerDialog.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 2788
🏁 Script executed:
# Look for card click handlers that might modify selectedNodePacks
rg -A 10 'onClick|@click' src/workbench/extensions/manager/components/manager/ManagerDialog.vue | head -40Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1211
🏁 Script executed:
# Search for isRightPanelOpen usage throughout the file
rg 'isRightPanelOpen' src/workbench/extensions/manager/components/manager/ManagerDialog.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 193
🏁 Script executed:
# Check BaseModalLayout to understand how rightPanel works
fd -t f 'BaseModalLayout' src/ --exec cat {} \;Repository: Comfy-Org/ComfyUI_frontend
Length of output: 21162
🏁 Script executed:
# Look for template structure around rightPanel
sed -n '1,100p' src/workbench/extensions/manager/components/manager/ManagerDialog.vue | grep -A 50 'template'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3222
Right panel won't auto-open when selection changes if count remains the same.
The watch only observes selectedNodePacks.value.length. When you close the panel and click a different card with the same selection count (e.g., 1 → 1), the watch doesn't trigger because the length hasn't changed. The panel stays closed instead of reopening, which conflicts with the expected behavior of auto-opening on card selection.
✅ Proposed fix
-watch(
- () => selectedNodePacks.value.length,
- (length) => {
- isRightPanelOpen.value = length > 0
- }
-)
+watch(
+ selectedNodePacks,
+ (packs) => {
+ isRightPanelOpen.value = packs.length > 0
+ },
+ { deep: true }
+)🤖 Prompt for AI Agents
In `@src/workbench/extensions/manager/components/manager/ManagerDialog.vue` around
lines 503 - 510, The watcher currently only observes
selectedNodePacks.value.length so it won't fire when the array contents change
but its length stays the same; update the watch to observe the array itself
(selectedNodePacks) and set isRightPanelOpen.value = packs.length > 0 in the
callback, or use watch(() => selectedNodePacks.value, (packs) => {...}, { deep:
true }) to detect item changes; adjust the watcher that references
selectedNodePacks/value and isRightPanelOpen to use the array watcher (and
deep:true if mutations keep the same array reference).
| key: string | ||
| component: Component | ||
| props: { onClose: () => void } | ||
| props: { onClose: () => void } & Record<string, unknown> |
There was a problem hiding this comment.
@coderabbitai Add an issue to fix the types here so that we don't need a catchall.
There was a problem hiding this comment.
🧩 Analysis chain
@DrJKL I'll create an issue to properly type the showLayoutDialog props instead of using the catch-all Record<string, unknown>.
🏁 Script executed:
#!/bin/bash
# Create a GitHub issue for fixing the type catch-all in showLayoutDialog
gh issue create \
--title "Fix type catch-all in showLayoutDialog props" \
--body "## Context
From PR `#8041`, comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/8041#discussion_r2697312371
## Issue
The \`showLayoutDialog\` function in \`src/services/dialogService.ts\` currently uses a catch-all type for props:
\`\`\`typescript
props: { onClose: () => void } & Record<string, unknown>
\`\`\`
This reduces type safety by allowing any additional properties without validation.
## Requested Action
Replace the \`Record<string, unknown>\` catch-all with properly typed props that reflect the actual properties that can be passed to this function.
## File Location
- File: \`src/services/dialogService.ts\`
- Function: \`showLayoutDialog\`
## Requested by
`@DrJKL`" \
--assignee DrJKL \
--label "enhancement"
Length of output: 57
@DrJKL I've created issue #8102 to properly type the showLayoutDialog props instead of using the Record<string, unknown> catch-all. The issue has been assigned to you and includes references back to this PR and comment.
🧬 Code Graph Analysis Results
[src/stores/dialogStore.ts] lines 37-38
export type DialogComponentProps = ComponentAttrs<typeof GlobalDialog> &
CustomDialogComponentProps
[src/stores/dialogStore.ts] lines 58-78
export interface ShowDialogOptions<
H extends Component = Component,
B extends Component = Component,
F extends Component = Component
> {
key?: string
title?: string
headerComponent?: H
footerComponent?: F
component: B
props?: ComponentAttrs<B>
headerProps?: ComponentAttrs<H>
footerProps?: ComponentAttrs<F>
dialogComponentProps?: DialogComponentProps
/**
* Optional priority for dialog stacking.
* A dialog will never be shown above a dialog with a higher priority.
* `@default` 1
*/
priority?: number
}
🧠 Learnings used
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Avoid using ts-expect-error; use proper TypeScript types instead
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Never use `as any` type assertions - fix the underlying type issue
DrJKL
added
cloud/1.37
needs-backport
|
Simplifies the Manager dialog by consolidating components and using BaseModalLayout with v-model support for right panel state. - **Consolidation**: Merged ManagerDialogContent, ManagerHeader, ManagerNavSidebar, RegistrySearchBar, and SearchFilterDropdown into single ManagerDialog component - **Right panel**: Added v-model:rightPanelOpen to BaseModalLayout for external panel state control; clicking a node card now auto-opens the info panel - **Cleanup**: Removed unused useResponsiveCollapse composable, TabItem and SearchOption types - **UI tweaks**: Moved action buttons (Install All/Update All) from header-right-area to contentFilter area [manager-capture.webm](https://github.com/user-attachments/assets/2dd6092a-965d-4885-8ba6-6a2cc51f024a) 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8041-refactor-Manager-dialog-simplification-2e86d73d3650815ba699e49a2748b682) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com>
Backport of #8041 to `cloud/1.37`. **Original PR:** #8041 ## Changes - Consolidated ManagerDialogContent, ManagerHeader, ManagerNavSidebar, RegistrySearchBar, and SearchFilterDropdown into single ManagerDialog component - Added v-model:rightPanelOpen to BaseModalLayout for external panel state control - Removed unused useResponsiveCollapse composable, TabItem and SearchOption types - Moved action buttons (Install All/Update All) from header-right-area to contentFilter area ## Conflict Resolution - **GlobalDialog.vue**: Kept settings-dialog-workspace styles, removed manager-dialog styles (now in BaseModalLayout) - **BaseModalLayout.vue**: Kept HEAD version (from #8256 backport) which has improved grid-based layout with accessibility features ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8306-backport-cloud-1-37-refactor-Manager-dialog-simplification-2f36d73d365081078518cc62ea736708) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <jin12cc@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com>
4 participants
Summary
Simplifies the Manager dialog by consolidating components and using BaseModalLayout with v-model support for right panel state.
Changes
manager-capture.webm
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito