Fix copylocks lint errors and Windows test failures in logging/common

[Copilot]

Two CI failures on the copilot/deep-test-analysis-go-project branch: golangci-lint rejecting illegal sync.Once copies in hit_test.go, and Windows unit tests failing because InitLogger never closes the log file it opens, causing t.TempDir() cleanup to fail with "file in use by another process".

Changes

pkg/logging/hit_test.go — remove illegal sync.Once copy

sync.Once contains sync.noCopy, making value assignment a go vet (copylocks) error. The save/restore of globalHitWriterOnce was unnecessary: restoring globalHitWriter to its original non-nil value is sufficient, since Hit() only calls setupGlobalHitWriter() when globalHitWriter == nil.

// Before (illegal — sync.Once cannot be copied)
origOnce := globalHitWriterOnce
defer func() { globalHitWriterOnce = origOnce }()

// After — only writer is saved/restored; Once is reset at setup only
globalHitWriterOnce = sync.Once{} // assigning zero value is fine

internal/cmd/common/common.go — expose log file closer

Added var logFileCloser io.Closer to the package vars, assigned in InitLogger when a file is opened. This gives tests (and future shutdown paths) a handle to release the OS file descriptor.

internal/cmd/common/common_test.go — close file before TempDir cleanup

In TestInitLogger_ConsoleMode and TestInitLogger_JSONMode, the defer now restores log.Logger first (stops writes), then closes logFileCloser (releases the handle). Go defers run before t.Cleanup callbacks, so the file is closed before t.TempDir() tries to remove it.

defer func() {
    log.Logger = origLogger          // stop writing to file first
    if logFileCloser != nil && logFileCloser != origLogFileCloser {
        _ = logFileCloser.Close()    // release OS handle before TempDir cleanup
    }
    logFileCloser = origLogFileCloser
    // restore other vars...
}()

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR improves the quality, isolation, and coverage of the Go test suite for Pipeleek’s CLI and helper packages by strengthening assertions, adding table-driven patterns, and enabling parallel execution where safe.

Changes:

• Refactors and strengthens CLI command tests using table-driven tests and testify (assert/require) assertions, including default flag value checks.
• Adds new unit tests for internal/cmd/common to cover previously untested exported helpers and logging behavior.
• Enables t.Parallel() across multiple pure/isolated tests in pkg/ to improve test runtime and reduce shared-state coupling.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/format/time_test.go	Updates ParseISO8601 tests to assert expected time.Time behavior and runs subtests in parallel.
pkg/format/string_test.go	Adds parallel execution to string helper tests (including subtests).
pkg/format/path_test.go	Runs directory-check tests and subtests in parallel.
pkg/format/format_test.go	Adds parallel execution to size/format-related tests and subtests.
pkg/config/validation_test.go	Adds parallel execution to validation tests and subtests.
pkg/archive/strings_test.go	Adds parallel execution across multiple string-extraction tests and subtests.
internal/cmd/root_test.go	Consolidates global log-level tests into a table-driven test and strengthens flag assertions.
internal/cmd/gitlab/jobToken/jobtoken_test.go	Converts manual assertions to testify and checks default flag values.
internal/cmd/gitlab/gitlab_test.go	Strengthens assertions and checks default values for key flags.
internal/cmd/devops/devops_test.go	Strengthens assertions and validates more flag defaults/shorthands.
internal/cmd/common/common_test.go	Adds new tests covering internal/cmd/common helpers (logging hooks/writers/flags/pre-run setup).