Skip to content

Fix copylocks lint errors and Windows test failures in logging/common #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frjcomp merged 9 commits into from
Mar 4, 2026
Merged

Fix copylocks lint errors and Windows test failures in logging/common #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
51a0348
Initial plan
Copilot Mar 3, 2026
efb61f3
Implement top 10 test improvements: table-driven, t.Parallel(), testi…
Copilot Mar 3, 2026
133cc57
Update internal/cmd/common/common_test.go
frjcomp Mar 3, 2026
70a0812
Add tests for weak coverage spots: privesc, config, docs, gitlab util…
Copilot Mar 3, 2026
f03546f
Refactor for testability: validateOrderBy returns error, extract dump…
Copilot Mar 3, 2026
54edc3b
Round 3: inject HTTP clients in FetchCurrentSelfHostedOptions, Extend…
Copilot Mar 3, 2026
f9adaaa
Round 4: Add tests for generateDocs, inlineSVGIntoGettingStarted, Ini…
Copilot Mar 3, 2026
f9b0309
Fix copylocks lint errors and Windows test failures in pkg/logging/hi…
Copilot Mar 4, 2026
06b53f7
Fix Windows test failures: close log file before TempDir cleanup in T…
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/cmd/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ var (
LogDebug bool
LogLevel string
IgnoreProxy bool
// logFileCloser holds the currently open log file so it can be closed on cleanup.
logFileCloser io.Closer
)

// TerminalRestorer is a function that can be called to restore terminal state
Expand Down Expand Up @@ -131,6 +133,7 @@ func InitLogger(cmd *cobra.Command) {
if err != nil {
panic(err)
}
logFileCloser = runLogFile
defaultOut = &CustomWriter{Writer: runLogFile}

rootFlags := cmd.Root().PersistentFlags()
Expand Down
Loading
Loading