Skip to content

Conversation

@kiblik
Copy link
Contributor

@kiblik kiblik commented Jan 30, 2026

Valkey chart does not enforce the existence of a dedicated service account. But it is a good idea to have it because of the best practice.

@github-actions github-actions bot added the helm label Jan 30, 2026
@kiblik kiblik force-pushed the feature/helm-valkey-sa branch from fb78f44 to 657d2e4 Compare January 30, 2026 18:11
@valentijnscholten valentijnscholten added this to the 2.55.0 milestone Jan 30, 2026
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro mtesauro merged commit 8dd3cd2 into DefectDojo:dev Feb 4, 2026
274 of 275 checks passed
@kiblik kiblik deleted the feature/helm-valkey-sa branch February 4, 2026 07:52
valentijnscholten pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 5, 2026
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants