Fix URI.encode error with newer rubies#24
Merged
jason-o-matic merged 4 commits intomasterfrom Jun 1, 2021
Merged
Conversation
`Kernel.open` for URIs is removed in newer rubies. This updates the tests to open URIs in a way that works across all upcoming ruby versions. swagger-api/swagger-codegen#10445 #22
This helps maintain compatibility with old versions as we add new ruby versions. #22
We'll be dropping support for old unsupported ruby versions, so this will cause the gemspec to be updated to reflect that. This is applied after client generation to update the generated file. #22 swagger-api/swagger-codegen#10445
This updates the client code to remove `URI.encode` usage since it has been removed from newer rubies. This is accomplished by updating the swagger-codegen version. #22 swagger-api/swagger-codegen#10445
mediocretes
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the client code to remove
URI.encodeusage since it has beenremoved from newer rubies. This is accomplished by updating the
swagger-codegen version.
This also adds easier multiple ruby version testing.
#22
swagger-api/swagger-codegen#10445