[RUBY] Replace deprecated URI.encode to support ruby 2.7 without warnings#10445
Merged
HugoMario merged 4 commits intoswagger-api:masterfrom Sep 2, 2020
Merged
[RUBY] Replace deprecated URI.encode to support ruby 2.7 without warnings#10445HugoMario merged 4 commits intoswagger-api:masterfrom
URI.encode to support ruby 2.7 without warnings#10445HugoMario merged 4 commits intoswagger-api:masterfrom
Conversation
Contributor
Author
|
Tests are failing due to un unrelated change in Typhoeus: typhoeus/typhoeus#575 An option would be to change that check, or another one, to call Thoughts? |
Contributor
Author
|
Pushed the second option to have the test passing. Let me know if you'd prefer an alternative, or a separate PR. |
Contributor
|
Thanks a lot for PR @kitop!! Here is fine :) |
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Issue: #10444
Ruby's URI.encode has been deprecated over 10 years ago. In addition, Ruby 2.7 now shows the warning in non-verbose mode, resulting in very noisy logs.
This tackles the problem via the second solution proposed in the issue.
It adds a dependency on the addressable gem, and uses Addressable::URI.encode which is part-aware.
Already tried this in a generated library with success: https://github.com/netlify/zuora-ruby-client/pull/7/files
/cc @zlx