Fix PG17 Logical Slot failover by keeping the dbname parameter in primary_conninfo#906
Open
vikrantmehta123 wants to merge 2 commits intoEnterpriseDB:masterfrom
Open
Fix PG17 Logical Slot failover by keeping the dbname parameter in primary_conninfo#906vikrantmehta123 wants to merge 2 commits intoEnterpriseDB:masterfrom
dbname parameter in primary_conninfo#906vikrantmehta123 wants to merge 2 commits intoEnterpriseDB:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres 17+ has support for logical slot failover, which requires
dbnameparameter to be set inprimary_conninfo.Files Changed:
repmgr-action-standby.cIn this PR, I changed the signature of the
write_primary_conninfoparameter to include the version number of Postgres. If the version number is greater than 17, we include thedbnameparameter in theprimary_conninfostring.I felt we could use the existing config for
dbnamein the primary_conninfo, hence I haven't made any changes to configurations.