Skip to content

Fix PG17 Logical Slot failover by keeping the dbname parameter in primary_conninfo #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikrantmehta123 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix PG17 Logical Slot failover by keeping the dbname parameter in primary_conninfo #906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8262fb
Added dbname support for syncing replication slots for pg17+
vikrantm-vunet Jan 14, 2026
9d28907
Merge branch 'EnterpriseDB:master' into vikrant-dev
vikrantmehta123 Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions repmgr-action-standby.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ static int get_tablespace_data_barman(char *, TablespaceDataList *);
static char *make_barman_ssh_command(char *buf);

static bool create_recovery_file(t_node_info *node_record, t_conninfo_param_list *primary_conninfo, int server_version_num, char *dest, bool as_file);
static void write_primary_conninfo(PQExpBufferData *dest, t_conninfo_param_list *param_list);
static void write_primary_conninfo(PQExpBufferData *dest, t_conninfo_param_list *param_list, int server_version_num);

static bool check_sibling_nodes(NodeInfoList *sibling_nodes, SiblingNodeStats *sibling_nodes_stats);
static bool check_free_wal_senders(int available_wal_senders, SiblingNodeStats *sibling_nodes_stats, bool *dry_run_success);
Expand Down Expand Up @@ -8221,7 +8221,7 @@ create_recovery_file(t_node_info *node_record, t_conninfo_param_list *primary_co
}

/* primary_conninfo = '...' */
write_primary_conninfo(&primary_conninfo_buf, primary_conninfo);
write_primary_conninfo(&primary_conninfo_buf, primary_conninfo, server_version_num);
key_value_list_set(&recovery_config,
"primary_conninfo", primary_conninfo_buf.data);

Expand Down Expand Up @@ -8363,7 +8363,7 @@ create_recovery_file(t_node_info *node_record, t_conninfo_param_list *primary_co


static void
write_primary_conninfo(PQExpBufferData *dest, t_conninfo_param_list *param_list)
write_primary_conninfo(PQExpBufferData *dest, t_conninfo_param_list *param_list, int server_version_num)
{
PQExpBufferData conninfo_buf;
bool application_name_provided = false;
Expand All @@ -8379,15 +8379,30 @@ write_primary_conninfo(PQExpBufferData *dest, t_conninfo_param_list *param_list)
for (c = 0; c < param_list->size && param_list->keywords[c] != NULL; c++)
{
/*
* Skip empty settings and ones which don't make any sense in
* recovery.conf
*/
if (strcmp(param_list->keywords[c], "dbname") == 0 ||
strcmp(param_list->keywords[c], "replication") == 0 ||
(param_list->values[c] == NULL) ||
* Skip empty settings and ones which don't make any sense in
* recovery.conf
*/
if ((param_list->values[c] == NULL) ||
(param_list->values[c] != NULL && param_list->values[c][0] == '\0'))
continue;

/*
* Skip "replication" - this is set automatically by libpq for
* replication connections.
*/
if (strcmp(param_list->keywords[c], "replication") == 0)
continue;

/*
* PostgreSQL 17 and later require "dbname" in primary_conninfo for
* failover replication slots (synchronized slots). Earlier versions
* don't need it and historically it was excluded.
*/
if (strcmp(param_list->keywords[c], "dbname") == 0 &&
server_version_num < 170000)
continue;


/* only include "password" if explicitly requested */
if (strcmp(param_list->keywords[c], "password") == 0)
{
Expand Down