Add warning when editing transaction start date#79295
Add warning when editing transaction start date#79295JmillsExpensify merged 2 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/pages/workspace/companyCards/WorkspaceCompanyCardEditTransactionStartDatePage.tsx
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-19.at.13.28.50.movAndroid: mWeb ChromeScreen.Recording.2026-01-19.at.13.28.50.moviOS: HybridAppScreen.Recording.2026-01-12.at.22.46.19.moviOS: mWeb SafariScreen.Recording.2026-01-12.at.22.39.51.movMacOS: Chrome / SafariScreen.Recording.2026-01-12.at.22.32.33.mov |
|
All yours @JmillsExpensify |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Agree we should add this given the side effects. Product approved.
|
All checks passed. Merging. |
|
🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.3.5-0 🚀
|
|
Hi @nyomanjyotisa. Can it be tested internally? QA team can't test adding a real company card |
|
Hi @IuliiaHerets, here’s a video showing how to add a company card to test this PR Username: user_good New-Expensify.mp4 |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀
|
|
🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.3.7-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.7-3 🚀
|
Explanation of Change
Add a confirmation or warning modal if the user edits the transaction start date on
WorkspaceCompanyCardEditTransactionStartDatePageFixed Issues
$ #79261
PROPOSAL: #79261 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4