[NO QA] Remove ONYXKEYS.COLLECTION.REPORT_VIOLATIONS#84673
[NO QA] Remove ONYXKEYS.COLLECTION.REPORT_VIOLATIONS#84673Julesssss merged 23 commits intoExpensify:mainfrom
Conversation
|
@MelvinBot Review it please |
Code ReviewOverall this is a clean removal of the Leftover dead codeThe PR removes the type mapping and all usages but leaves behind a few orphaned definitions:
Behavioral questionThe simplified Similarly, Minor nitThe variable name |
|
@MelvinBot Updated your suggestions. Could you please review again please? |
|
All three dead code items from my previous review have been addressed:
One minor formatting nit: Otherwise this looks good to me. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
trjExpensify
and removed request for
a team
|
The failing test is also on main |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aff39a07ca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Show field violations only for control policies | ||
| if (isControlPolicy(policy) && iouReport) { | ||
| const {optimisticData: fieldViolationsOptimisticData, failureData: fieldViolationsFailureData} = getFieldViolationsOnyxData(iouReport); | ||
| onyxData.optimisticData?.push(...(fieldViolationsOptimisticData ?? [])); | ||
| onyxData.failureData?.push(...(fieldViolationsFailureData ?? [])); | ||
| } | ||
|
|
There was a problem hiding this comment.
@hungvu193 It is only safe to remove this if the condition in line 3095 is always true
if (!policy || !isPaidGroupPolicy(policy) || transaction.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
So violationsOnyxData also should be removed if we removed this
There was a problem hiding this comment.
Please help to confirm this one before removing
There was a problem hiding this comment.
This condition:
transaction.reportID === CONST.REPORT.UNREPORTED_REPORT_IDis always true for track expense so it's safe to remove it. I'll remove the rest condition as well
There was a problem hiding this comment.
@hungvu193 Please ping me when it's done. Thanks
|
@hungvu193 the rest looks fine to me |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
Merged main into this branch successfully. |
|
Good bot 😄 |
Julesssss
left a comment
Julesssss
left a comment
There was a problem hiding this comment.
@hungvu193 could please just update the description with details of what this is doing, and places which may have been affected (in case this PR is pointed to in relation to a regression)
Updated! |
|
@MelvinBot resolve conflicts and merge main please. |
Co-authored-by: Hans <hungvu193@users.noreply.github.com> # Conflicts: # src/pages/Debug/Report/DebugReportPage.tsx
|
Merged The conflict was caused by |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
oh hey, this plus #85199 (just merged this morning) is making typecheck/lint/etc. very sad. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
This reverts commit feb5f3d, re-landing the changes from PR Expensify#84673. Made-with: Cursor
This reverts commit feb5f3d, re-landing the changes from PR Expensify#84673. Made-with: Cursor Fix semantic conflicts with Expensify#85199 (GBR report field errors) - Remove reportViolations param from hasVisibleReportFieldViolations - Update getFieldViolation call to single-arg form - Remove REPORT_VIOLATIONS from reportAttributes dependencies/compute - Fix OnyxDerivedTest to match reduced dependency count Made-with: Cursor
7 participants
Explanation of Change
This PR follows up on #66423.
As discussed previously, we’ve removed the usage of
ONYXKEYS.COLLECTION.REPORT_VIOLATIONSsince it’s no longer used anywhere and the associated logic has become redundant.Since
reportViolationsis strictly FE and consistently empty or undefined wherever it appears, removing it is safe.However, since we modified the violations logic, we need to make sure the RBR displays correctly on these following places:
Fixed Issues
$ #66423
PROPOSAL: N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari