Skip to content

Pass disabled prop to Checkbox in RadioListItem for parent categories#85852

Open
MelvinBot wants to merge 6 commits intomainfrom
claude-fixDisabledCheckboxForParentCategories
Open

Pass disabled prop to Checkbox in RadioListItem for parent categories#85852
MelvinBot wants to merge 6 commits intomainfrom
claude-fixDisabledCheckboxForParentCategories

Conversation

@MelvinBot
Copy link
Contributor

Explanation of Change

The Checkbox rendered by RadioListItem's defaultRightHandSideComponent (used in the Default Spend Category selector) was not receiving the disabled prop. This caused parent categories in multi-level hierarchies to display visually enabled, clickable checkboxes — even though the row itself was correctly disabled via BaseListItem.

This change passes isDisabled through to the Checkbox component so it correctly shows as disabled (reduced opacity, not-allowed cursor) and blocks interaction for parent categories.

Fixed Issues

$ #85848
PROPOSAL: #85848 (comment)

Tests

  1. Create a workspace and navigate to Categories
  2. Add a multi-level category (e.g., "TestParent: TestChild: TestLeaf")
  3. Go to Categories > Settings
  4. Click on any Default Spend Category MCC group (e.g., "Airlines")
  5. Verify parent categories ("TestParent", "TestChild") have disabled checkboxes (grayed out, not-allowed cursor)
  6. Verify clicking on parent category checkboxes does nothing
  7. Verify leaf category ("TestLeaf") checkbox is still clickable and selectable
  • Verify that no errors appear in the JS console

Offline tests

N/A — This is a UI-only change that affects checkbox disabled state styling. No network requests are involved.

QA Steps

  1. Create a workspace and navigate to Categories
  2. Add a multi-level category (e.g., "A: B: C")
  3. Go to Categories > Settings
  4. Click on any Default Spend Category MCC group
  5. Verify parent categories ("A", "A: B") show disabled checkboxes
  6. Verify clicking on parent category checkboxes does not select them
  7. Verify the leaf category ("A: B: C") is selectable
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — Web-only bug

Android: mWeb Chrome

N/A — Web-only bug

iOS: Native

N/A — Web-only bug

iOS: mWeb Safari

N/A — Web-only bug

MacOS: Chrome / Safari

Tested via Playwright: parent categories ("TestParent", "TestChild") now show cursor: not-allowed and disabled checkbox styling, while the leaf category ("TestLeaf") remains interactive with cursor: pointer.

…omponent

The Checkbox in RadioListItem's defaultRightHandSideComponent was not
receiving the disabled prop, so it appeared visually enabled and was
clickable for disabled parent categories in multi-level category
selectors. This passes isDisabled through to the Checkbox so it
correctly shows as disabled and blocks interaction.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 19, 2026 19:02
@MelvinBot
Copy link
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixDisabledCheckboxForParentCategories
git checkout -b claude-fixDisabledCheckboxForParentCategories upstream/claude-fixDisabledCheckboxForParentCategories
git push -u origin claude-fixDisabledCheckboxForParentCategories

Then you can close this PR and open a new one from your fork.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing typecheck: coerced isDisabled (which can be boolean | null | undefined) to a strict boolean with \!\! before passing it to the Checkbox disabled prop (which expects boolean | undefined).

The other failing check (build (developmentDebug, false)) is unrelated to this PR — it's an Android build infrastructure issue (missing expo/scripts/autolinking.gradle).

…ckboxForParentCategories

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing checks by merging main into the branch.

PR-related failure (already fixed): The TypeScript error in RadioListItem.tsx:51 (Type 'boolean | null | undefined' is not assignable to type 'boolean | undefined') was already resolved in commit e8fd466 by coercing isDisabled with !!.

Unrelated failures (fixed by merge): The branch was behind main, which caused:

  • TypeScript errors in reportAttributes.ts and ReportUtils.ts referencing REPORT_VIOLATIONS (recently renamed/removed in main)
  • A Jest test failure in ReportUtilsTest.ts for hasVisibleReportFieldViolations

The merge with main resolves these. New CI checks are now running.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's changes.

This PR only modifies: src/components/SelectionList/ListItem/RadioListItem.tsx

Failing checks and why they're unrelated:

  1. TypeScript check — Errors are in src/libs/ReportUtils.ts and src/libs/actions/OnyxDerived/configs/reportAttributes.ts, referencing REPORT_VIOLATIONS and ReportViolations which don't exist in the codebase. This appears to be an incomplete feature in main that was brought in via the merge commit.

  2. build (developmentDebug, false) — Android build fails with Could not read script '.../node_modules/expo/scripts/autolinking.gradle' as it does not exist. This is a build infrastructure/dependency issue unrelated to any code change in this PR.

Evidence: Neither ReportUtils.ts, reportAttributes.ts, nor any Android build configuration file appears in this PR's diff. The single file changed (RadioListItem.tsx) passes all relevant checks (Changed files ESLint, Prettier, unused styles, etc.).

These failures should resolve once the underlying issues in main are fixed.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's changes.

This PR only modifies: src/components/SelectionList/ListItem/RadioListItem.tsx

Failing checks:

  1. typecheck — Errors in src/libs/actions/OnyxDerived/configs/reportAttributes.ts and src/libs/ReportUtils.ts referencing ONYXKEYS.COLLECTION.REPORT_VIOLATIONS and a ReportViolations type, neither of which exist in ONYXKEYS.ts. These same references exist on main — this is a pre-existing issue, not introduced by this PR.

  2. build (developmentDebug, false) — Android build fails with Could not read script 'node_modules/expo/scripts/autolinking.gradle' as it does not exist. This is a CI/infrastructure issue unrelated to the code change.

Evidence: Both reportAttributes.ts and ONYXKEYS.ts on origin/main show the same mismatch — REPORT_VIOLATIONS is referenced but not defined. The typecheck would fail on any branch based on current main.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR. This PR only modifies src/components/SelectionList/ListItem/RadioListItem.tsx, but all failures are in different files:

Typecheck — Errors in src/libs/ReportUtils.ts and src/libs/actions/OnyxDerived/configs/reportAttributes.ts referencing ReportViolations/REPORT_VIOLATIONS which don't exist. Pre-existing on main.

ESLint — Warnings-as-errors in WorkspaceOwnerChangeErrorPage.tsx, WorkspaceOwnerChangeSuccessPage.tsx, WorkspacePerDiemPage.tsx, and ChangeReceiptBillingAccountPage.tsx (react-hooks rules). Pre-existing on main.

Test (job 2)ReportUtilsTest.ts failure in hasVisibleReportFieldViolations test. Pre-existing on main.

Build (developmentDebug) — Missing node_modules/expo/scripts/autolinking.gradle — a build infrastructure/dependency issue. Pre-existing on main.

None of these failures are related to the disabled prop change in RadioListItem.tsx. They should resolve once the upstream main branch fixes land.

@MelvinBot
Copy link
Contributor Author

The failing checks on this PR are not caused by this PR's changes. This PR only modifies src/components/SelectionList/ListItem/RadioListItem.tsx, but all failures are in unrelated files.

Root cause: PR #84673 ("[NO QA] Remove ONYXKEYS.COLLECTION.REPORT_VIOLATIONS") removed the REPORT_VIOLATIONS key from ONYXKEYS.ts but did not update all references. Specifically, src/libs/actions/OnyxDerived/configs/reportAttributes.ts still uses ONYXKEYS.COLLECTION.REPORT_VIOLATIONS in multiple places (lines 23, 74, 120, 237), and src/libs/ReportUtils.ts references the removed ReportViolations type.

This broke main, causing cascading failures:

  • typecheck: 15 errors in reportAttributes.ts and ReportUtils.ts about missing REPORT_VIOLATIONS key and ReportViolations type
  • ESLint: 93 errors / 306 warnings (pre-existing on main, unrelated to this PR)
  • test (job 2): ReportUtilsTest.tshasVisibleReportFieldViolations test fails because the underlying function's signature changed
  • build failures: Cascade from typecheck errors

Evidence: The last PR merged before this breakage (#85849) passed all these checks. PR #84673 was merged immediately after and introduced the breakage. The files failing in CI are identical between this branch and main — this PR does not modify any of them.

These failures will resolve once main is fixed (the leftover REPORT_VIOLATIONS references in reportAttributes.ts and ReportUtils.ts need to be cleaned up).

@Krishna2323
Copy link
Contributor

@MelvinBot try merging main now

@Krishna2323
Copy link
Contributor

@MelvinBot merge main

…ckboxForParentCategories

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Done — merged main into this branch and pushed. The merge was clean with no conflicts.

@Krishna2323
Copy link
Contributor

@MelvinBot mark it ready for review

@MelvinBot
Copy link
Contributor Author

The failing check build (developmentDebug, false) is unrelated to this PR.

Analysis: The error is Could not read script 'node_modules/expo/scripts/autolinking.gradle' as it does not exist — this is an Android build infrastructure issue in the Remote Build Android workflow, not a code issue.

Evidence: Every recent run of the Remote Build Android workflow is failing, including runs on main:

  • main — failed (2026-03-19T20:43:17Z)
  • main — failed (2026-03-19T20:20:03Z)
  • main — failed (2026-03-19T20:10:07Z)
  • main — failed (2026-03-19T20:09:39Z)

This PR only modifies src/components/SelectionList/ListItem/RadioListItem.tsx (adding the isDisabled prop to a Checkbox component), which has no relation to the Android Gradle build pipeline. All other checks (ESLint, Prettier, Storybook, spellcheck, CLA, etc.) are passing.

@MelvinBot
Copy link
Contributor Author

The branch is already up to date with main — no new commits to merge.

@MelvinBot MelvinBot marked this pull request as ready for review March 19, 2026 22:02
@MelvinBot MelvinBot requested a review from a team as a code owner March 19, 2026 22:02
@MelvinBot
Copy link
Contributor Author

Done — PR has been marked as ready for review.

@melvin-bot melvin-bot bot requested review from Krishna2323 and removed request for a team March 19, 2026 22:02
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team March 19, 2026 22:02
@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's code changes.

Failing checks:

  1. build (developmentDebug, false) (Android): Could not read script 'node_modules/expo/scripts/autolinking.gradle' as it does not exist — a dependency resolution issue in the CI build environment
  2. build (New Expensify Dev, DebugDevelopment, false) (iOS): Native build infrastructure failure

Why these are unrelated:

  • This PR only modifies src/components/SelectionList/ListItem/RadioListItem.tsx (adding disabled={!!isDisabled} to a Checkbox component — a 2-line TypeScript change)
  • All code quality checks pass: ESLint, typecheck, all 8 test jobs, prettier, storybook, spellcheck
  • The non-development debug builds also pass (build (Debug, true) and build (Expensify Dev, Debug, true))
  • The branch is fully up-to-date with main

Recommendation: Re-run the failed workflows. These appear to be transient CI infrastructure issues (missing expo autolinking script in node_modules for Android, and a build environment issue for iOS).

@Krishna2323
Copy link
Contributor

Krishna2323 commented Mar 20, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: HybridApp
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4

@Krishna2323
Copy link
Contributor

@MelvinBot please merge main again 😄

…ckboxForParentCategories

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team as a code owner March 20, 2026 11:09
@MelvinBot
Copy link
Contributor Author

Merged main into this branch and pushed. The PR is now up to date.

@melvin-bot melvin-bot bot requested a review from marcaaron March 20, 2026 11:09
@melvin-bot
Copy link

melvin-bot bot commented Mar 20, 2026

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 20, 2026 11:09
@MelvinBot
Copy link
Contributor Author

The failing build (developmentDebug, false) check is unrelated to this PR.

Analysis: The failure is an Android build infrastructure issue — node_modules/expo/scripts/autolinking.gradle does not exist. This PR only modifies src/components/SelectionList/ListItem/RadioListItem.tsx, which has nothing to do with the Android build system.

Evidence: The same Remote Build Android workflow is also failing on the main branch, confirming this is a pre-existing repo-wide issue.

Copy link
Contributor

@Krishna2323 Krishna2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

The failing checks are not related.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's changes.

Failing checks:

  • build (developmentDebug, false) — Android build fails with: Could not read script '.../node_modules/expo/scripts/autolinking.gradle' as it does not exist. This is an expo/node_modules environment issue in CI.
  • build (New Expensify Dev, DebugDevelopment, false) — iOS build also fails (likely same infra issue).

Evidence: This PR only modifies src/components/SelectionList/ListItem/RadioListItem.tsx (passing isDisabled to a Checkbox). The build failures are in the Gradle/expo autolinking setup, which is unrelated. The same build workflow is also failing on main branch runs, confirming this is a pre-existing CI infrastructure issue.

@Krishna2323
Copy link
Contributor

@MelvinBot merge main again 🤖

…ckboxForParentCategories

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Merged main into this branch and pushed. The PR is now up to date.

@MelvinBot
Copy link
Contributor Author

The failing perf-tests check is unrelated to this PR's changes.

Analysis: The failure is a transient network connectivity error — the GitHub Actions runner could not reach github.com:443 during the git fetch origin main step (Failed to connect to github.com port 443 after 133660 ms: Couldn't connect to server).

Evidence: The PR only modifies src/components/SelectionList/RadioListItem.tsx to pass a disabled prop to a Checkbox. The perf-test failure occurred before any test code ran, during a git fetch operation.

Re-running the workflow should resolve this.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's changes (which only pass the disabled prop to Checkbox in RadioListItem).

build (Debug, true) — Android build infrastructure failure. The Hermes engine cmake build step failed with: A problem occurred starting process 'command '/usr/local/lib/android/sdk/cmake/3.30.5/bin/cmake''. This is a CI environment/toolchain issue, not a code issue.

perf-tests — Network connectivity failure on the CI runner: Failed to connect to github.com port 443 after 133660 ms: Couldn't connect to server. The job couldn't even fetch origin/main.

Both should pass on a re-run.

@MelvinBot
Copy link
Contributor Author

The failing checks are unrelated to this PR's changes (only src/components/SelectionList/ListItem/RadioListItem.tsx was modified).

Failing checks:

  • build (Debug, true) — Android build failed due to a cmake/Hermes engine infra issue: Execution failed for task ':react-native:packages:react-native:ReactAndroid:hermes-engine:buildHermesC' — A problem occurred starting process 'command cmake'
  • build (New Expensify Dev, DebugDevelopment, false) — iOS build failed due to remote cache miss: NoSuchKey: The specified key does not exist
  • perf-tests — Network connectivity timeout: Failed to connect to github.com port 443 after 133660 ms

All three are CI infrastructure/network issues. Re-running the failed checks should resolve them.

@marcaaron
Copy link
Contributor

@MelvinBot Can you merge main again?

@MelvinBot
Copy link
Contributor Author

I'd be happy to merge main, but I can only make code changes when directed by the PR author, an assignee, or an existing co-author. Krishna2323 — would you like me to merge main into this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants