feat(datasource-customizer): implement gmail-style search#780
Conversation
88ac783 to
5d9a614
Compare
|
With the following commits, I've added the support of the following syntax: The separator The same way, the operator |
…changing the current behavior
|
|
||
| export default class CustomErrorStrategy extends DefaultErrorStrategy { | ||
| override reportError(): void { | ||
| // We don't want console logs when parsing fails |
There was a problem hiding this comment.
What could cause the parser to fail ? What would happen then ? normal search ?
There was a problem hiding this comment.
If the query does not respect the syntax (unmatched parenthesis). In this case we fallback and consider the whole searched string as a unique token to search.
| return string; | ||
| } | ||
|
|
||
| function pad(month: number) { |
There was a problem hiding this comment.
you could use native month.toString().padStart(2, '0')
realSpok
left a comment
There was a problem hiding this comment.
- ✅ Code review
- ✅ Use pure functions when possible
- ✅ Performance concerns
- ✅ Security concerns
- ✅ The PR tackle one subject only
- ✅ Automatic tests
- ✅ Unit tests
- ✅ Integration tests
- ✅ Manual tests
- ✅ Test the functionality
- ✅ Test error cases
- ✅ PR title
- ✅ Destination branch
- ✅ PR linked to the clickup task
Some minor non blocking comments
|
Code Climate has analyzed commit 7afd86a and detected 42 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 83.6% (98% is the threshold). This pull request will bring the total coverage in the repository to 97.3% (-1.6% change). View more on Code Climate. |
## [1.6.78](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.6.78) (2024-01-26) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
## [1.36.18](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
# [1.41.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
# [1.1.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
|
🎉 This PR is included in version 1.0.71 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
# [1.6.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
## [1.0.60](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
# [1.6.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
## [1.7.45](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
|
🎉 This PR is included in version 1.6.78 🎉 The release is available on Your semantic-release bot 📦🚀 |
# [1.30.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
## [1.25.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
## [1.3.59](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
## [1.0.84](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8))
|
🎉 This PR is included in version 1.36.18 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.60 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
* fix: disableFieldSorting is now only preventing frontend to sort the collection * chore(release): @forestadmin/[email protected] [skip ci] ## @forestadmin/datasource-replica [1.0.58](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Dependencies * **@forestadmin/datasource-customizer:** upgraded to 1.40.3 * chore(release): [email protected] [skip ci] ## [1.6.75](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.6.75) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.36.15](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.40.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.93](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.3.57](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.69](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.82](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * fix(replaceFieldWriting): force customer to give a replaceFieldWriting definition to avoid emulation when null is given (#913) * chore(release): @forestadmin/[email protected] [skip ci] ## @forestadmin/datasource-replica [1.0.59](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Dependencies * **@forestadmin/datasource-customizer:** upgraded to 1.40.4 * chore(release): [email protected] [skip ci] ## [1.6.76](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.6.76) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.36.16](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.40.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.94](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.3.58](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.70](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.83](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-22) ### Bug Fixes * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * fix: return more details in errors due to certificate validation to help debugging (#917) * chore(release): @forestadmin/[email protected] [skip ci] ## @forestadmin/forestadmin-client [1.25.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-23) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) * chore(release): [email protected] [skip ci] ## [1.6.77](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.6.77) (2024-01-23) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.36.17](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-23) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) * refactor(example): fix agent typings (#920) * refactor: bump nodejs version used in github actions (#919) * feat(datasource-customizer): implement gmail-style search (#780) * chore(release): @forestadmin/[email protected] [skip ci] ## @forestadmin/plugin-export-advanced [1.0.71](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Dependencies * **@forestadmin/datasource-customizer:** upgraded to 1.41.0 * **@forestadmin/datasource-toolkit:** upgraded to 1.30.0 * chore(release): [email protected] [skip ci] ## [1.6.78](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.6.78) (2024-01-26) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.36.18](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] # [1.41.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] # [1.1.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] # [1.6.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.60](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] # [1.6.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.7.45](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] # [1.30.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * disableFieldSorting is now only preventing frontend to sort the collection ([7f1481b](7f1481b)) * **replaceFieldOperator:** disallow to pass null because it will emulate instead to remove the operator ([#911](#911)) ([bf0c105](bf0c105)) * **replaceFieldWriting:** force customer to give a replaceFieldWriting definition to avoid emulation when null is given ([#913](#913)) ([b0b1862](b0b1862)) * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.25.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.3.59](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) * chore(release): @forestadmin/[email protected] [skip ci] ## [1.0.84](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-01-26) ### Bug Fixes * return more details in errors due to certificate validation to help debugging ([#917](#917)) ([58aaaec](58aaaec)) ### Features * **datasource-customizer:** implement gmail-style search ([#780](#780)) ([3ad8ed8](3ad8ed8)) --------- Co-authored-by: Enki <[email protected]> Co-authored-by: Forest Bot <[email protected]> Co-authored-by: scra <[email protected]> Co-authored-by: Guillaume Gautreau <[email protected]> Co-authored-by: Romain Gilliotte <[email protected]> Co-authored-by: Nicolas Moreau <[email protected]>
|
🎉 This PR is included in version 1.0.0-beta-cloud-customizer.11 🎉 The release is available on npm package (@beta-cloud-customizer dist-tag) Your semantic-release bot 📦🚀 |
You can try the following search strings