Fix Linux Python package CI builds

[dzenanz]

They will be needed for easy/automated PyPI package generation and uploading. The main issue is TensorBoard failing to build using manylinux toolchain, as detailed in google/tensorstore#69.

[dzenanz]

I tried removing ASM setting from docker image. My effort seems completely ignored:

[1023/2055] Building ASM object _deps/zstd-build/CMakeFiles/Zstd_zstdlib.dir/lib/decompress/huf_decompress_amd64.S.o
FAILED: _deps/zstd-build/CMakeFiles/Zstd_zstdlib.dir/lib/decompress/huf_decompress_amd64.S.o 
/opt/rh/gcc-toolset-11/root/bin//as --defsym XXH_NAMESPACE=ZSTD_ --defsym ZSTDLIB_HIDDEN="" --defsym ZSTDLIB_VISIBLE="" -I/work/ITK-source/ITK/Modules/ThirdParty/Eigen3/src/itkeigen/.. -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/Eigen3/src -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/KWSys/src -I/work/oneTBB-prefix/include -I/work/ITK-source/ITK/Modules/ThirdParty/VNL/src/vxl/v3p/netlib -I/work/ITK-source/ITK/Modules/ThirdParty/VNL/src/vxl/vcl -I/work/ITK-source/ITK/Modules/ThirdParty/VNL/src/vxl/core -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/VNL/src/vxl/v3p/netlib -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/VNL/src/vxl/vcl -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/VNL/src/vxl/core -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/Core/Common -I/work/ITK-source/ITK/Modules/Core/Common/include -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/IO/ImageBase -I/work/ITK-source/ITK/Modules/IO/ImageBase/include -I/work/ITK-source/ITK/Modules/IO/HDF5/include -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/ZLIB/src -I/work/ITK-cp37-cp37m-manylinux_2_28_x64/Modules/ThirdParty/ZLIB/src/itkzlib-ng -I/work/ITK-source/ITK/Modules/ThirdParty/ZLIB/src -I/work/include -I/work/_skbuild/linux-x86_64-3.7/cmake-build/include -I/work/_skbuild/linux-x86_64-3.7/cmake-build/_deps/zstd-build -I/work/_skbuild/linux-x86_64-3.7/cmake-build/_deps/zstd-build/lib -I/work/_skbuild/linux-x86_64-3.7/cmake-build/_deps/zstd-src -I/work/_skbuild/linux-x86_64-3.7/cmake-build/_deps/zstd-src/lib -O3 -DNDEBUG -fPIC -I/work/_skbuild/linux-x86_64-3.7/cmake-build/_deps/zstd-src/lib/common --MD _deps/zstd-build/CMakeFiles/Zstd_zstdlib.dir/lib/decompress/huf_decompress_amd64.S.o.d -o _deps/zstd-build/CMakeFiles/Zstd_zstdlib.dir/lib/decompress/huf_decompress_amd64.S.o -c /work/_skbuild/linux-x86_64-3.7/cmake-build/_deps/zstd-src/lib/decompress/huf_decompress_amd64.S
/opt/rh/gcc-toolset-11/root/bin//as: invalid option -- 'N'

As I don't have permission to push docker images to dockcross, I pushed them to my fork. Maybe that is the problem? Or packaging scripts need a more thorough modification than this? Or the modification to docker files themselves is insufficient?

[thewtex]

Did the wheels build successfully locally? This should be tried first.

[dzenanz]

The docker image did build. I never succeeded at building wheels, either locally or in the CI.

[thewtex]

The wheels for this module should be built locally first.

[dzenanz]

The error message is the same.

[thewtex]

Please verify that the desired docker image is used.

[dzenanz]

Removing ASM specifications gets me past the main issue (google/tensorstore#69), but runs into a different error. I think it is the toolchain compatibility identified in InsightSoftwareConsortium/ITK#3785 (comment). Simply trying to revert dockcross to gcc11 runs into:

++ MANYLINUX_VERSION=_2_28
++ echo 'Building wheels for x64 using manylinux_2_28'
Building wheels for x64 using manylinux_2_28
+ sudo ldconfig
/opt/rh/gcc-toolset-12/root/usr/bin/sudo: line 41: /usr/bin/sudo: No such file or directory
Cleaning up artifacts from module build

[dzenanz]

@tbirdso do you know how to fix /opt/rh/gcc-toolset-12/root/usr/bin/sudo: line 41: /usr/bin/sudo: No such file or directory?

[thewtex]

As discussed at InsightSoftwareConsortium/ITK#3785 (comment)
your dockcross patches should be added to a Git branch based on dockcross 459c9f0.

[dzenanz]

That does it. The wheel builds locally with dzenanz/dockcross@1aeaea0, zarrCI branch of ITKPythonPackage InsightSoftwareConsortium/ITKPythonPackage@857e352. Current master, my fork's master and and https://github.com/dzenanz/ITKIOOMEZarrNGFF/tree/tensorstore should all build.

@thewtex I do not have permission to push 20230104-1aeaea0 tag to dockcross dockerhub. Could you do it, or give me permission?

[thewtex]

@dzenanz great news!

dockcross/manylinux_2_28-x64:20230106-1aeaea0 have been pushed to DockerHub. Please create a PR with the branch to the dockcross repository.

[dzenanz]

I created a PR: dockcross/dockcross#760. I tested with just removing CMAKE_ASM_COMPILER, and that was sufficient for building ITKIOOMEZarrNGFF package.