ENH: Use ITKPythonPackage with updated dockcross#14
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 7, 2023
Merged
ENH: Use ITKPythonPackage with updated dockcross#14thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
tbirdso
reviewed
Jan 9, 2023
Collaborator
tbirdso
left a comment
tbirdso
left a comment
There was a problem hiding this comment.
@dzenanz Very nice, congrats!
I see that 88581ec3 is on a zarrCI development branch in ITKPythonPackage. Is the intention that this will be merged into ITKPythonPackage@main in the near future or instead maintain it as a separate branch?
Member
Author
|
It should be merged, via a merge commit so the sha1 used here remain valid. PR open: InsightSoftwareConsortium/ITKPythonPackage#249. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13. Closes google/tensorstore#69.