Skip to content

Move kron and diagonal tests out of core linalg tests#663

Merged
christiangnrd merged 2 commits intomasterfrom
splittest
Dec 3, 2025
Merged

Move kron and diagonal tests out of core linalg tests#663
christiangnrd merged 2 commits intomasterfrom
splittest

Conversation

@christiangnrd
Copy link
Copy Markdown
Member

Motivated by attempting to fix OpenCL.jl windows CI (JuliaGPU/OpenCL.jl#405), but the linalg/core testset allocates 2x more than any other testsuite, so I think splitting off the two most allocation-heavy testsets into their own testsuites is a good idea regardless.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/testsuite/linalg.jl b/test/testsuite/linalg.jl
index 17da632..794e6ab 100644
--- a/test/testsuite/linalg.jl
+++ b/test/testsuite/linalg.jl
@@ -299,7 +299,7 @@ end
 @testsuite "linalg/diagonal" (AT, eltypes) -> begin
     @testset "Array + Diagonal" begin
         n = 128
-        A = AT(rand(Float32, (n,n)))
+        A = AT(rand(Float32, (n, n)))
         d = AT(rand(Float32, n))
         D = Diagonal(d)
         B = A + D
@@ -324,7 +324,7 @@ end
         @test collect(cholesky(D).U) ≈ collect(cholesky(F).U)
         @test collect(cholesky(D).L) ≈ collect(cholesky(F).L)
 
-        d = AT([1f0, 2f0, -1f0, 0f0])
+        d = AT([1.0f0, 2.0f0, -1.0f0, 0.0f0])
         D = Diagonal(d)
         @test cholesky(D, check = false).info == 3
     end
@@ -420,7 +420,7 @@ end
     end
 
     @testset "$f with diagonal $d" for f in (triu, triu!, tril, tril!),
-                                        d in -2:2
+            d in -2:2
         A = randn(Float32, 10, 10)
         @test compare(f, AT, A, d)
 
diff --git a/test/testsuite/random.jl b/test/testsuite/random.jl
index 5e00682..15c5bbb 100644
--- a/test/testsuite/random.jl
+++ b/test/testsuite/random.jl
@@ -25,7 +25,7 @@
             Random.seed!(rng, 1)
             rand!(rng, B)
 
-            @test Array(A) == Array(B) skip=SEEDING_BROKEN && (prod(d) > length(rng.state))
+            @test Array(A) == Array(B) skip = SEEDING_BROKEN && (prod(d) > length(rng.state))
 
             if rng != cpu_rng
                 rand!(cpu_rng, A)
@@ -65,7 +65,7 @@
             randn!(rng, A)
             Random.seed!(rng, 1)
             randn!(rng, B)
-            @test Array(A) == Array(B) skip=SEEDING_BROKEN && (prod(d) > (2 * length(rng.state)))
+            @test Array(A) == Array(B) skip = SEEDING_BROKEN && (prod(d) > (2 * length(rng.state)))
 
             if rng != cpu_rng
                 randn!(cpu_rng, A)

@christiangnrd christiangnrd changed the title Move kron and diagonal tests from core linalg tests Move kron and diagonal tests out of core linalg tests Nov 28, 2025
@christiangnrd
Copy link
Copy Markdown
Member Author

Also skips broken rand tests (#530) since they apparently sometimes succeed with OpenCL.jl

Copy link
Copy Markdown
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Splitting up these testsets is definitely a good thing.

@christiangnrd christiangnrd merged commit d9ec8e3 into master Dec 3, 2025
19 checks passed
@christiangnrd christiangnrd deleted the splittest branch December 3, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants